In identifying what templates still use Greybox for Bug 8290 I found two templates which contain obsolete references to Greybox code: authorities/merge.tt cataloguing/z3950_auth_search.tt
Created attachment 51839 [details] [review] Bug 16600 - Remove some obsolete references to Greybox in some templates This patch removes unused Greybox markup from two templates. To test, apply the patch and go to Authorities. - Perform an authority search which will return multiple results. - Select two records to merge. - On the "merging records" page, an earlier version used Greybox to show a preview of the selected authority records. Confirm that authority number link for the two records triggers a pop-up window instead. - From the authorities home page, choose 'New from Z39.50' - Perform a search which will return multiple results. - Confirm that there is only a 'MARC' preview link. A forever-commented-out 'Card' link has been removed.
Created attachment 52867 [details] [review] [SIGNED-OFF]Bug 16600: Remove some obsolete references to Greybox in some templates This patch removes unused Greybox markup from two templates. To test, apply the patch and go to Authorities. - Perform an authority search which will return multiple results. - Select two records to merge. - On the "merging records" page, an earlier version used Greybox to show a preview of the selected authority records. Confirm that authority number link for the two records triggers a pop-up window instead. - From the authorities home page, choose 'New from Z39.50' - Perform a search which will return multiple results. - Confirm that there is only a 'MARC' preview link. A forever-commented-out 'Card' link has been removed. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised. Obsolete comment on 'Card' removed
Created attachment 52875 [details] [review] Bug 16600 - Remove some obsolete references to Greybox in some templates This patch removes unused Greybox markup from two templates. To test, apply the patch and go to Authorities. - Perform an authority search which will return multiple results. - Select two records to merge. - On the "merging records" page, an earlier version used Greybox to show a preview of the selected authority records. Confirm that authority number link for the two records triggers a pop-up window instead. - From the authorities home page, choose 'New from Z39.50' - Perform a search which will return multiple results. - Confirm that there is only a 'MARC' preview link. A forever-commented-out 'Card' link has been removed. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised. Obsolete comment on 'Card' removed Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed to master for 16.11, thanks Owen!
Pushed in 16.05. Will be in 16.05.02.