In koha-tmpl/intranet-tmpl/prog/en/modules/auth.tt, a tag-isolated word "please" leads to translation problems (syntax in different languages). Line 81: please <a href="[% casServerUrl %]">click here to login</a>.<p>
Created attachment 51921 [details] [review] Bug 16620: Translatability: Fix problem with isolated word "please" in auth.tt This patch fixes a translatability problem (syntax in different languages) with a tag-isolated word "please" in koha-tmpl/intranet-tmpl/prog/en/modules/auth.tt To test: - Verify in code that in line 81 the word "please" is inside the a-tag.
Oh, there are more syntax problems...
Created attachment 51922 [details] [review] Bug 16620: Translatability: Fix problem with isolated word "please" in auth.tt This patch fixes a translatability problem (syntax in different languages) with a tag-isolated word "please" in koha-tmpl/intranet-tmpl/prog/en/modules/auth.tt To test: - Verify in code that there is no sentence spliting by a-tags (lines 80/84).
Same problem exists in OPAC. Maybe do it in one go?
(In reply to Srdjan Jankovic from comment #4) > Same problem exists in OPAC. Maybe do it in one go? Ah, yes. opac-auth.tt lines 90 and following. This could go to Bug 16540: Translatability in opac-auth.tt
Created attachment 51956 [details] [review] [SIGNED-OFF] Bug 16620: Translatability: Fix problem with isolated word "please" in auth.tt This patch fixes a translatability problem (syntax in different languages) with a tag-isolated word "please" in koha-tmpl/intranet-tmpl/prog/en/modules/auth.tt To test: - Verify in code that there is no sentence spliting by a-tags (lines 80/84). Signed-off-by: Srdjan <srdjan@catalyst.net.nz>
Created attachment 52155 [details] [review] Bug 16620: Translatability: Fix problem with isolated word "please" in auth.tt This patch fixes a translatability problem (syntax in different languages) with a tag-isolated word "please" in koha-tmpl/intranet-tmpl/prog/en/modules/auth.tt To test: - Verify in code that there is no sentence spliting by a-tags (lines 80/84). Signed-off-by: Srdjan <srdjan@catalyst.net.nz> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed to master for 16.11, thanks Marc!
Pushed in 16.05. Will be in 16.05.01.
Patch pushed to 3.22.x, will be in 3.22.8