reports/cat_issues_top.pl does not export "Count of checkouts" column as CSV To replicate: 1/ Make sure that test instance has circulation in a given date range 2/ Go to Home › Reports › Most-circulated items 3/ Select a date range 4/ Select 'To screen into the browser' radio button, click submit. 5/ Note that Columns 'Rank/Biblioitemnumbers', 'Global' and 'Count of checkouts' appear in screen output. 6/ Click the browser's back button 7/ Change output to 'To a file', click submit. 8/ Note that the columns "100/", "Global" and "Total" are exported to the CSV file. "100/" contains the rank, "Global" is still global, and the "Total" column is empty.
Encountered this today. I guess no-one is actually using this report and saving the output to CSV.
Created attachment 75886 [details] [review] Bug 16653: Display number of checkouts when exporting 'Most-circulated items' as CSV reports/cat_issues_top.pl does not export "Count of checkouts" column as CSV To replicate: 1/ Make sure that test instance has circulation in a given date range 2/ Go to Home › Reports › Most-circulated items 3/ Select a date range 4/ Select 'To screen into the browser' radio button, click submit. 5/ Note that Columns 'Rank/Biblioitemnumbers', 'Global' and 'Count of checkouts' appear in screen output. 6/ Click the browser's back button 7/ Change output to 'To a file', click submit. Without this patch: the columns "100/", "Global" and "Total" are exported to the CSV file. "100/" contains the rank, "Global" is still global, and the "Total" column is empty. With this patch patch applied, the last column is filled and the "Total" line is removed (This script is really dirty)
Created attachment 75937 [details] [review] Bug 16653: Display number of checkouts when exporting 'Most-circulated items' as CSV reports/cat_issues_top.pl does not export "Count of checkouts" column as CSV To replicate: 1/ Make sure that test instance has circulation in a given date range 2/ Go to Home › Reports › Most-circulated items 3/ Select a date range 4/ Select 'To screen into the browser' radio button, click submit. 5/ Note that Columns 'Rank/Biblioitemnumbers', 'Global' and 'Count of checkouts' appear in screen output. 6/ Click the browser's back button 7/ Change output to 'To a file', click submit. Without this patch: the columns "100/", "Global" and "Total" are exported to the CSV file. "100/" contains the rank, "Global" is still global, and the "Total" column is empty. With this patch patch applied, the last column is filled and the "Total" line is removed (This script is really dirty) Signed-off-by: Pierre-Luc Lapointe <pierreluc.lapointe@inLibro.com>
Created attachment 76376 [details] [review] Bug 16653: Display number of checkouts when exporting 'Most-circulated items' as CSV reports/cat_issues_top.pl does not export "Count of checkouts" column as CSV To replicate: 1/ Make sure that test instance has circulation in a given date range 2/ Go to Home › Reports › Most-circulated items 3/ Select a date range 4/ Select 'To screen into the browser' radio button, click submit. 5/ Note that Columns 'Rank/Biblioitemnumbers', 'Global' and 'Count of checkouts' appear in screen output. 6/ Click the browser's back button 7/ Change output to 'To a file', click submit. Without this patch: the columns "100/", "Global" and "Total" are exported to the CSV file. "100/" contains the rank, "Global" is still global, and the "Total" column is empty. With this patch patch applied, the last column is filled and the "Total" line is removed (This script is really dirty) Signed-off-by: Pierre-Luc Lapointe <pierreluc.lapointe@inLibro.com> (Yes it is) Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Created attachment 76377 [details] [review] Bug 16653: (QA follow-up) Avoid a warning and remove unused variables Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Awesome work all! Pushed to master for 18.11
Pushed to 18.05.x for 18.05.02, trivial bugfix.
Pushed to 17.11.x for 17.11.08