The patch for bug 16442 happened to change the implicit return values for C4::Ris::print_title() and C4::Ris::print_stitle(), thereby breaking two tests t/Ris.t. However... on reflection those two tests are not very useful, as they test the return value of two routines that neither advertise nor supply any return value: their sole purpose is to calculate some values and print them to STDOUT.
Created attachment 52108 [details] [review] Bug 16674: remove two tests from t/Ris.t This patch removes two tests that were broken by the patch for bug 16442, thus preventing packages from being build in master. Ordinarily, one would either fix the tests or change the code that broke the tests... but as the tests in question check the return value of routines that do not actually advertise a return value, I've elected to simply remove them. To test ------- [1] Verify that t/Ris.t passes. Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Created attachment 52198 [details] [review] [SIGNED-OFF]Bug 16674: remove two tests from t/Ris.t This patch removes two tests that were broken by the patch for bug 16442, thus preventing packages from being build in master. Ordinarily, one would either fix the tests or change the code that broke the tests... but as the tests in question check the return value of routines that do not actually advertise a return value, I've elected to simply remove them. To test ------- [1] Verify that t/Ris.t passes. Signed-off-by: Galen Charlton <gmcharlt@gmail.com> Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
*** This bug has been marked as a duplicate of bug 16668 ***