Bug 16674 - remove two broken test from t/Ris.t
Summary: remove two broken test from t/Ris.t
Status: RESOLVED DUPLICATE of bug 16668
Alias: None
Product: Koha
Classification: Unclassified
Component: Test Suite (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Chris Cormack
QA Contact: Galen Charlton
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-06-07 01:58 UTC by Galen Charlton
Modified: 2016-06-10 13:30 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 16674: remove two tests from t/Ris.t (1.20 KB, patch)
2016-06-07 02:07 UTC, Galen Charlton
Details | Diff | Splinter Review
[SIGNED-OFF]Bug 16674: remove two tests from t/Ris.t (1.28 KB, patch)
2016-06-09 15:25 UTC, Héctor Eduardo Castro Avalos
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Galen Charlton 2016-06-07 01:58:23 UTC
The patch for bug 16442	happened to change the implicit return values for C4::Ris::print_title() and C4::Ris::print_stitle(), thereby breaking two tests t/Ris.t.

However... on reflection those two tests are not very useful, as they test the return value of two routines that neither advertise nor supply any return value: their sole purpose is to calculate some values and print them to STDOUT.
Comment 1 Galen Charlton 2016-06-07 02:07:11 UTC Comment hidden (obsolete)
Comment 2 Héctor Eduardo Castro Avalos 2016-06-09 15:25:50 UTC
Created attachment 52198 [details] [review]
[SIGNED-OFF]Bug 16674: remove two tests from t/Ris.t

This patch removes two tests that were broken by the patch for
bug 16442, thus preventing packages from being build in master.

Ordinarily, one would either fix the tests or
change the code that broke the tests... but as the tests in
question check the return value of routines that do not
actually advertise a return value, I've elected to simply
remove them.

To test
-------
[1] Verify that t/Ris.t passes.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Comment 3 Jonathan Druart 2016-06-10 13:30:07 UTC

*** This bug has been marked as a duplicate of bug 16668 ***