In Koha version 16.05, the links from the online help to koha manual are broken. To reproduce: In staff client (e.g. About page), click on 'Help' at the top right af the screen. Then click on link 'manual' in "See the full documentation for the About page in the manual (online)." Result: For 16.05: http://manual.koha-community.org/16.4/en/aboutkoha.html The requested URL /16.4/en/aboutkoha.html was not found on this server. For current master (16.06.00.002): http://manual.koha-community.org/16.06/en/aboutkoha.html The requested URL /16.06/en/aboutkoha.html was not found on this server. The correct link should be (for both): The requested URL /16.05/en/aboutkoha.html was not found on this server.
Note: Version number for help files is calculated in help.pl line 68 ff
Calculation was introduced for 3.14.x ( by Bug 11238 - The version of the manual online link should be dynamically updated ).
Created attachment 52339 [details] [review] Bug 16724: Fix link to the online documentation links Since the numbering changes, the online doc links are broken. Test plan: Make sure the online doc links work on the help pages.
Created attachment 52340 [details] [review] Bug 16724 - Link from online help to manual broken (as of version 16.05) To test: - apply patch - load some page in staff client, open help, check the link to the manual for 16.05, it should include 16.05 for master, it should include 16.05 for versions < 16, it should still work as before This will work for xx.05 and xx.11 releases. If we will have xx.04 or xx.06 at some point, it has to be adjusted.
Created attachment 52341 [details] [review] Bug 16724: Fix link to the online documentation links Since the numbering changes, the online doc links are broken. Test plan: Make sure the online doc links work on the help pages. Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net>
It displays OK with 16.05 and 16.06, but what about future versions? E.g. 16.07, 16.08 (will result in a link to http://manual.koha-community.org/16.07/en/ ) and 16.09, 16.10 (will result in a link to http://manual.koha-community.org/16.09/en/
The numbers for stable should always be .05 and .11 (may and november) currently - so that might work ok.
Comment on attachment 52341 [details] [review] Bug 16724: Fix link to the online documentation links Review of attachment 52341 [details] [review]: ----------------------------------------------------------------- ::: help.pl @@ +69,5 @@ > if ( $help_version =~ m|^(\d+)\.(\d{2}).*$| ) { > my $version = $1; > my $major = $2; > + unless ( $major % 2 ) { $major-- }; > + $major = sprintf("%02d", $major); Why not put the sprintf on the next line and remove the interpolation too? :) This works too, though.
(In reply to M. Tompsett from comment #8) > Comment on attachment 52341 [details] [review] [review] > Bug 16724: Fix link to the online documentation links > > Review of attachment 52341 [details] [review] [review]: > ----------------------------------------------------------------- > > ::: help.pl > @@ +69,5 @@ > > if ( $help_version =~ m|^(\d+)\.(\d{2}).*$| ) { > > my $version = $1; > > my $major = $2; > > + unless ( $major % 2 ) { $major-- }; > > + $major = sprintf("%02d", $major); > > Why not put the sprintf on the next line and remove the interpolation too? :) > This works too, though. I don't understand. Do you suggest $help_version = $version . '.' . sprintf("%02d", $major); ?
Created attachment 52539 [details] [review] [PASSED QA] Bug 16724: Fix link to the online documentation links Since the numbering changes, the online doc links are broken. Test plan: Make sure the online doc links work on the help pages. Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for Koha 16.11, thanks Jonathan!
Pushed in 16.05. Will be in 16.05.02.
Not needed in 3.22.x