It seems that sub itemissues, defined in C4/Circulation.pm, is never used. Behalve of C4/Circulation.pm it is only found (but not used) in: catalogue/moredetail.pl:use C4::Circulation; # to use itemissues To verify: - git grep itemissues - comment out line 33 in catalogue/moredetail.pl, verifiy that there are no errors or side effects
Created attachment 54259 [details] [review] Bug 16741 - Remove dead code "sub itemissues" from C4/Circulation.pm To verify: - git grep itemissues Result: Appears in C4/Circulation.pm only To test: - apply patch - git grep itemissues Expected result: No occurences - prove t/db_dependent/Circulation.t Expected result: Pass OK
Created attachment 54284 [details] [review] Bug 16741 - Remove dead code "sub itemissues" from C4/Circulation.pm To verify: - git grep itemissues Result: Appears in C4/Circulation.pm only To test: - apply patch - git grep itemissues Expected result: No occurences - prove t/db_dependent/Circulation.t Expected result: Pass OK Signed-off-by: Claire Gravely <c.gravely@arts.ac.uk>
Created attachment 54289 [details] [review] Bug 16741 - Remove dead code "sub itemissues" from C4/Circulation.pm To verify: - git grep itemissues Result: Appears in C4/Circulation.pm only To test: - apply patch - git grep itemissues Expected result: No occurences - prove t/db_dependent/Circulation.t Expected result: Pass OK Signed-off-by: Claire Gravely <c.gravely@arts.ac.uk> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed to master for 16.11, thanks Marc!
Pushed in 16.05. Will be in 16.05.03.