I'm working on patches to remove event attributes likes 'onclick' and 'onchange' from several acquisitions-related templates: transferorder.tt uncertainprices.tt aqbudgets.tt
Created attachment 52458 [details] [review] Bug 16752 - Remove the use of event attributes from some acquisitions templates - Transfer order This patch removes the use of 'onclick' from the acquisitions transfer order process. The patch also modifies the style of some links and buttons to conform with current guidelines. - Locate an open basket with items in it - Click the 'Transfer' link for a title in the basket - In the pop-up window: - Confirm that the 'Cancel' button at the bottom of the window is a Bootstrap-style button. - Search for a vendor; Confirm that the 'Choose' link is a Bootstrap-style button. - Choose a vendor; Confirm that the 'Choose' link on the following page is a Bootstrap-style button. - Confirm that clicking the 'Choose' button transfers the item to the correct basket.
Created attachment 52459 [details] [review] Bug 16752 - Remove the use of event attributes from some acquisitions templates - Uncertain prices This patch modifies the acquisitions uncertain prices template to remove event attributes onclick and onchange. Also changed on the uncertain prices page: Added a label to the orders filter, removed redundant form submit function. - Locate a vendor which has orders with uncertain prices - Click the 'Uncertain prices' tab in the left-hand sidebar - Enter invalid data in the "price" field for any order. Confirm that an error is triggered when the field loses focus.
Created attachment 52460 [details] [review] Bug 16752 - Remove the use of event attributes from some acquisitions templates - Funds This patch modifies the funds administration page and other files related to the process of searching for and selecting fund owners and users in order to remove the use of event attributes like 'onclick.' Also changed in this patch: I have revised the way the "select owner" and "select user" controls look. They are now links with Font Awesome icons. - Go to Administration -> Funds and open a fund for editing. - Test the process of adding and updating an owner: - Click the 'Select owner' link. - Search for and select an owner in the pop-up window. - Save the fund and verify that the owner was saved correctly. - Perform the same test with the 'Remove owner' link. - Use the same process to test the addition and removal of users. - Confirm that the 'Remove' link works correctly before and after submitting the form to save changes to the fund. This patch changes a file which is used by both the funds template and the template used when setting a guarantor on a patron. To test the changes in that context: - Open a 'child' type patron record. - Under 'Guarantor information,' test the process of setting and removing a guarantor to confirm that data is saved correctly.
Comment on attachment 52458 [details] [review] Bug 16752 - Remove the use of event attributes from some acquisitions templates - Transfer order Hi Owen >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/transferorder.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/transferorder.tt >+ $(doocument).ready(function(){ >+ $(".confirm_transfer").on("click",function(){ >+ return confirm( _("Transfer order to this basket?") ); >+ }); >+ }); > //]]> I think there is a typo in your first patch "doocument"
(In reply to Héctor Eduardo Castro Avalos from comment #4) > I think there is a typo in your first patch "doocument" Don't be afraid to mark something as "Failed QA." You don't have to be QA manager to do it.
Created attachment 53569 [details] [review] Bug 16752 - Remove the use of event attributes from some acquisitions templates - Transfer order This patch removes the use of 'onclick' from the acquisitions transfer order process. The patch also modifies the style of some links and buttons to conform with current guidelines. - Locate an open basket with items in it - Click the 'Transfer' link for a title in the basket - In the pop-up window: - Confirm that the 'Cancel' button at the bottom of the window is a Bootstrap-style button. - Search for a vendor; Confirm that the 'Choose' link is a Bootstrap-style button. - Choose a vendor; Confirm that the 'Choose' link on the following page is a Bootstrap-style button. - Confirm that clicking the 'Choose' button transfers the item to the correct basket.
Created attachment 54737 [details] [review] [SIGNED-OFF] Bug 16752 - Remove the use of event attributes from some acquisitions templates - Uncertain prices This patch modifies the acquisitions uncertain prices template to remove event attributes onclick and onchange. Also changed on the uncertain prices page: Added a label to the orders filter, removed redundant form submit function. - Locate a vendor which has orders with uncertain prices - Click the 'Uncertain prices' tab in the left-hand sidebar - Enter invalid data in the "price" field for any order. Confirm that an error is triggered when the field loses focus. Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com>
Created attachment 54738 [details] [review] [SIGNED-OFF] Bug 16752 - Remove the use of event attributes from some acquisitions templates - Funds This patch modifies the funds administration page and other files related to the process of searching for and selecting fund owners and users in order to remove the use of event attributes like 'onclick.' Also changed in this patch: I have revised the way the "select owner" and "select user" controls look. They are now links with Font Awesome icons. - Go to Administration -> Funds and open a fund for editing. - Test the process of adding and updating an owner: - Click the 'Select owner' link. - Search for and select an owner in the pop-up window. - Save the fund and verify that the owner was saved correctly. - Perform the same test with the 'Remove owner' link. - Use the same process to test the addition and removal of users. - Confirm that the 'Remove' link works correctly before and after submitting the form to save changes to the fund. This patch changes a file which is used by both the funds template and the template used when setting a guarantor on a patron. To test the changes in that context: - Open a 'child' type patron record. - Under 'Guarantor information,' test the process of setting and removing a guarantor to confirm that data is saved correctly. Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com>
Created attachment 54739 [details] [review] [SIGNED-OFF] Bug 16752 - Remove the use of event attributes from some acquisitions templates - Transfer order This patch removes the use of 'onclick' from the acquisitions transfer order process. The patch also modifies the style of some links and buttons to conform with current guidelines. - Locate an open basket with items in it - Click the 'Transfer' link for a title in the basket - In the pop-up window: - Confirm that the 'Cancel' button at the bottom of the window is a Bootstrap-style button. - Search for a vendor; Confirm that the 'Choose' link is a Bootstrap-style button. - Choose a vendor; Confirm that the 'Choose' link on the following page is a Bootstrap-style button. - Confirm that clicking the 'Choose' button transfers the item to the correct basket. Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com>
I am not sure to understand how uncertainprices.pl is supposed to work but I think have found a regression: - Change the price to something wrong - focus out => alert - Change the price to something ok - Save => nothing happens
Created attachment 54933 [details] [review] [SIGNED-OFF] Bug 16752 [Revised] Remove the use of event attributes from some acquisitions templates - Uncertain prices This patch modifies the acquisitions uncertain prices template to remove event attributes onclick and onchange. Also changed on the uncertain prices page: Added a label to the orders filter, removed redundant form submit function. - Locate a vendor which has orders with uncertain prices - Click the 'Uncertain prices' tab in the left-hand sidebar - Enter invalid data in the "price" field for any order. Confirm that an error is triggered when the field loses focus. Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com> QA Revision: Corrected input type of submit button.
Created attachment 54935 [details] [review] Bug 16752 - Remove the use of event attributes from some acquisitions templates - Funds This patch modifies the funds administration page and other files related to the process of searching for and selecting fund owners and users in order to remove the use of event attributes like 'onclick.' Also changed in this patch: I have revised the way the "select owner" and "select user" controls look. They are now links with Font Awesome icons. - Go to Administration -> Funds and open a fund for editing. - Test the process of adding and updating an owner: - Click the 'Select owner' link. - Search for and select an owner in the pop-up window. - Save the fund and verify that the owner was saved correctly. - Perform the same test with the 'Remove owner' link. - Use the same process to test the addition and removal of users. - Confirm that the 'Remove' link works correctly before and after submitting the form to save changes to the fund. This patch changes a file which is used by both the funds template and the template used when setting a guarantor on a patron. To test the changes in that context: - Open a 'child' type patron record. - Under 'Guarantor information,' test the process of setting and removing a guarantor to confirm that data is saved correctly. Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 54936 [details] [review] Bug 16752 - Remove the use of event attributes from some acquisitions templates - Transfer order This patch removes the use of 'onclick' from the acquisitions transfer order process. The patch also modifies the style of some links and buttons to conform with current guidelines. - Locate an open basket with items in it - Click the 'Transfer' link for a title in the basket - In the pop-up window: - Confirm that the 'Cancel' button at the bottom of the window is a Bootstrap-style button. - Search for a vendor; Confirm that the 'Choose' link is a Bootstrap-style button. - Choose a vendor; Confirm that the 'Choose' link on the following page is a Bootstrap-style button. - Confirm that clicking the 'Choose' button transfers the item to the correct basket. Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 54937 [details] [review] Bug 16752 [Revised] Remove the use of event attributes from some acquisitions templates - Uncertain prices This patch modifies the acquisitions uncertain prices template to remove event attributes onclick and onchange. Also changed on the uncertain prices page: Added a label to the orders filter, removed redundant form submit function. - Locate a vendor which has orders with uncertain prices - Click the 'Uncertain prices' tab in the left-hand sidebar - Enter invalid data in the "price" field for any order. Confirm that an error is triggered when the field loses focus. Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com> QA Revision: Corrected input type of submit button. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed to master for 16.11, thanks Owen!