Caused by my patch for Bug 5006: In record matching rules, if you remove the last match check, the entire match check container is deleted, including the controls for adding a new match check.
Created attachment 52498 [details] [review] Bug 16762 - Record matching rules: Remove match check link removes too much My patch for Bug 5006 introduced a lot of markup changes to the record matching rules template. I missed a change in one are though, which caused a bug with the way the 'Remove match check' link works. To reproduce: - Go to Administration -> Record matching rules. - Edit a matching rule which includes at least one match check. - Click a 'Remove match check' link. The entire "Required match checks" block is removed. To test, apply the patch and repeat the steps above. Clicking any 'Remove match check' link should remove only the corresponding rule.
Created attachment 52699 [details] [review] [SIGNED-OFF]Bug 16762: Record matching rules: Remove match check link removes too much My patch for Bug 5006 introduced a lot of markup changes to the record matching rules template. I missed a change in one are though, which caused a bug with the way the 'Remove match check' link works. To reproduce: - Go to Administration -> Record matching rules. - Edit a matching rule which includes at least one match check. - Click a 'Remove match check' link. The entire "Required match checks" block is removed. To test, apply the patch and repeat the steps above. Clicking any 'Remove match check' link should remove only the corresponding rule. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised
Created attachment 52700 [details] [review] [SIGNED-OFF]Bug 16762: Record matching rules: Remove match check link removes too much My patch for Bug 5006 introduced a lot of markup changes to the record matching rules template. I missed a change in one are though, which caused a bug with the way the 'Remove match check' link works. To reproduce: - Go to Administration -> Record matching rules. - Edit a matching rule which includes at least one match check. - Click a 'Remove match check' link. The entire "Required match checks" block is removed. To test, apply the patch and repeat the steps above. Clicking any 'Remove match check' link should remove only the corresponding rule. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised
Created attachment 52815 [details] [review] Bug 16762: Record matching rules: Remove match check link removes too much My patch for Bug 5006 introduced a lot of markup changes to the record matching rules template. I missed a change in one are though, which caused a bug with the way the 'Remove match check' link works. To reproduce: - Go to Administration -> Record matching rules. - Edit a matching rule which includes at least one match check. - Click a 'Remove match check' link. The entire "Required match checks" block is removed. To test, apply the patch and repeat the steps above. Clicking any 'Remove match check' link should remove only the corresponding rule. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Pushed to master for 16.11, thanks Owen!
Pushed in 16.05. Will be in 16.05.02.
Patch pushed to 3.22.x, will be in 3.22.10