From C4/languages.pm: 32 eval { 33 if (C4::Context->ismemcached) { 34 require Memoize::Memcached; 35 import Memoize::Memcached qw(memoize_memcached); 36 37 memoize_memcached('getTranslatedLanguages', memcached => C4::Context->memcached); 38 memoize_memcached('getFrameworkLanguages' , memcached => C4::Context->memcached); 39 memoize_memcached('getAllLanguages', memcached => C4::Context->memcached); 40 } 41 }; Looking at this code, you might think these subroutines are cached, but actually they are not. The eval surrounding the code hides a bug, if you remove it, you will get: Invalid memcached argument (expected a hash)
Created attachment 52513 [details] [review] Bug 16770: Remove wrong caching of 3 subroutines in C4::Lancuages ooking at this code, you might think these subroutines are cached, but actually they are not. The eval surrounding the code hides a bug, if you remove it, you will get: Invalid memcached argument (expected a hash) Test plan: Do not apply this patch and confirm that the code does not work
Created attachment 52514 [details] [review] Bug 16770: Remove Memoize::Memcached dependency This module is no loguer in used and can be removed.
Created attachment 52515 [details] [review] Bug 16770: Remove Memoize::Memcached dependency This module is no longer in used and can be removed.
Created attachment 52555 [details] [review] Bug 16770: Remove wrong caching of 3 subroutines in C4::Lancuages ooking at this code, you might think these subroutines are cached, but actually they are not. The eval surrounding the code hides a bug, if you remove it, you will get: Invalid memcached argument (expected a hash) Test plan: Do not apply this patch and confirm that the code does not work Signed-off-by: Jacek Ablewicz <abl@biblos.pk.edu.pl>
Created attachment 52556 [details] [review] Bug 16770: Remove wrong caching of 3 subroutines in C4::Lancuages ooking at this code, you might think these subroutines are cached, but actually they are not. The eval surrounding the code hides a bug, if you remove it, you will get: Invalid memcached argument (expected a hash) Test plan: Do not apply this patch and confirm that the code does not work Signed-off-by: Jacek Ablewicz <abl@biblos.pk.edu.pl>
Created attachment 52557 [details] [review] Bug 16770: Remove Memoize::Memcached dependency This module is no longer in use and can be removed. Signed-off-by: Jacek Ablewicz <abl@biblos.pk.edu.pl> This part involves some changes in a bunch of mysterious debian|ubuntu related files, not quite sure if I know what I'm doing
Some references to 'memoize' are still left in ./install_misc/ubuntu.10.04.packages:libmemoize-memcached-perl install ./install_misc/ubuntu.12.04.packages:libmemoize-memcached-perl install not sure if those files (whatever they are) are still relevent or not?
Created attachment 52640 [details] [review] Bug 16770: Remove 2 other occurrences of libmemoize-memcached-perl
(In reply to Jacek Ablewicz from comment #7) > Some references to 'memoize' are still left in > > ./install_misc/ubuntu.10.04.packages:libmemoize-memcached-perl install > ./install_misc/ubuntu.12.04.packages:libmemoize-memcached-perl install > > not sure if those files (whatever they are) are still relevent or not? They should be removed as well indeed.
Created attachment 52678 [details] [review] Bug 16770: Remove 2 other occurrences of libmemoize-memcached-perl Signed-off-by: Jacek Ablewicz <abl@biblos.pk.edu.pl>
Created attachment 52712 [details] [review] Bug 16770: Remove wrong caching of 3 subroutines in C4::Lancuages ooking at this code, you might think these subroutines are cached, but actually they are not. The eval surrounding the code hides a bug, if you remove it, you will get: Invalid memcached argument (expected a hash) Test plan: Do not apply this patch and confirm that the code does not work Signed-off-by: Jacek Ablewicz <abl@biblos.pk.edu.pl> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 52713 [details] [review] Bug 16770: Remove Memoize::Memcached dependency This module is no longer in use and can be removed. Signed-off-by: Jacek Ablewicz <abl@biblos.pk.edu.pl> This part involves some changes in a bunch of mysterious debian|ubuntu related files, not quite sure if I know what I'm doing Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 52714 [details] [review] Bug 16770: Remove 2 other occurrences of libmemoize-memcached-perl Signed-off-by: Jacek Ablewicz <abl@biblos.pk.edu.pl> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Pushed to master for 16.11, thanks Jonathan!
Pushed in 16.05. Will be in 16.05.02.
Patches pushed to 3.22.x, will be in 3.22.10