Add a dropup button "Action" with Awesome icons for "Delete" and "Edit"
Created attachment 52674 [details] [review] Bug 16794: Revise layout for Admistration > Categories Add a dropup button "Action" with Awesome icons for "Delete" and "Edit" To test - Go to Administration -> Categories - Confirm that a button "Action" appear instead of links. - Also see the new icons for "Edit" and "Delete" - Edit an existing category and confirm that works as expected - Delete a category and confirm that works properly.
Created attachment 52676 [details] [review] Bug 16794 - Revise layout for Admistration > Categories Add a dropup button "Action" with Awesome icons for "Delete" and "Edit" To test - Go to Administration -> Categories - Confirm that a button "Action" appear instead of links. - Also see the new icons for "Edit" and "Delete" - Edit an existing category and confirm that works as expected - Delete a category and confirm that works properly. Signed-off-by: Marc Véron <veron@veron.ch>
I disagree that the links should be in a menu. I think in all other cases if there are only two actions we display actions as buttons. It's when there are three or more actions that we use a menu. I think one could argue that this page should be an exception because of the size of the table, but I would counter that perhaps we should trim down the number of columns displayed instead.
Created attachment 52697 [details] [review] Bug 16794: Revise layout for Admistration > Patron categories Add Bootstrap buttons and Font Awesome Icons to "Delete" and "Edit" links To test - Go to Administration -> Patron categories - Confirm that two button appear instead of links for "Edit" and "Delete" - Edit an existing category and confirm that works as expected - Delete a category and confirm that works properly. Patch fix it according with QA comment 3
Created attachment 52703 [details] [review] Bug 16794: Revise layout for Admistration > Patron categories Add Bootstrap buttons and Font Awesome Icons to "Delete" and "Edit" links To test - Go to Administration -> Patron categories - Confirm that two button appear instead of links for "Edit" and "Delete" - Edit an existing category and confirm that works as expected - Delete a category and confirm that works properly. Patch fix it according with QA comment 3 Buttons appear now as requested in comment #3 (2 buttons, no action menu) Signed-off-by: Marc Véron <veron@veron.ch>
Comment on attachment 52703 [details] [review] Bug 16794: Revise layout for Admistration > Patron categories Review of attachment 52703 [details] [review]: ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/modules/admin/categories.tt @@ +318,4 @@ > [% END %] > <th scope="col">Branches limitations</th> > <th scope="col">Default privacy</th> > + <th aria-label="Actions" style="width: 88.1px;" colspan="1" rowspan="1" class="sorting_disabled">Actions</th> This looks like a copy and paste from DataTables-generated markup. I don't think we need anything more than '<th scope="col">Actions</th>' in the template.
Created attachment 52856 [details] [review] Bug 16794: (follow up) Change scope header to col only Fix copy and paste according with QA comment 6
Column Default privacy can't be sorted anymore.
Created attachment 53002 [details] [review] Bug 16794: (follow up)Make column "Default privacy" could be sorted again Fix column "Default privacy" to be sorted again according with comment 8
Created attachment 53003 [details] [review] Bug 16794: Revise layout for Admistration > Patron categories Add Bootstrap buttons and Font Awesome Icons to "Delete" and "Edit" links To test - Go to Administration -> Patron categories - Confirm that two button appear instead of links for "Edit" and "Delete" - Edit an existing category and confirm that works as expected - Delete a category and confirm that works properly. Patch fix it according with QA comment 3 Fix copy and paste according with QA comment 6 Fix column "Default privacy" to be sorted again according with comment 8 Patch set squashed Buttons appear now as requested in comment #3 (2 buttons, no action menu) Signed-off-by: Marc Véron <veron@veron.ch>
Created attachment 53048 [details] [review] Bug 16794: Revise layout for Admistration > Patron categories Add Bootstrap buttons and Font Awesome Icons to "Delete" and "Edit" links To test - Go to Administration -> Patron categories - Confirm that two button appear instead of links for "Edit" and "Delete" - Edit an existing category and confirm that works as expected - Delete a category and confirm that works properly. Patch fix it according with QA comment 3 Fix copy and paste according with QA comment 6 Fix column "Default privacy" to be sorted again according with comment 8 Patch set squashed Buttons appear now as requested in comment #3 (2 buttons, no action menu) Re-tested, works as expected. Signed-off-by: Marc Véron <veron@veron.ch>
The 2 buttons should be grouped into the same column.
(In reply to Jonathan Druart from comment #12) > The 2 buttons should be grouped into the same column. Nevermind, I will provide a follow-up.
Created attachment 53057 [details] [review] Bug 16794: Revise layout for Admistration > Patron categories Add Bootstrap buttons and Font Awesome Icons to "Delete" and "Edit" links To test - Go to Administration -> Patron categories - Confirm that two button appear instead of links for "Edit" and "Delete" - Edit an existing category and confirm that works as expected - Delete a category and confirm that works properly. Patch fix it according with QA comment 3 Fix copy and paste according with QA comment 6 Fix column "Default privacy" to be sorted again according with comment 8 Patch set squashed Buttons appear now as requested in comment #3 (2 buttons, no action menu) Re-tested, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 53058 [details] [review] Bug 16794: Group the 2 action buttons into the same column Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed to master for 16.11,t hanks Hector!
Pushed in 16.05. Will be in 16.05.02.