We should alert during installation, restart, or upgrade for all daemon services stopping and starting. For example, stopping and starting the SIP server alerts during the apt install process. We expect (and sometimes depend on) things like Apache and MySQL(MariaDB) telling us when they are restarting during upgrades, I think we should treat our daemons the same way. All this really means is making the init.d run koha-plack without --quiet.
Created attachment 53720 [details] [review] Bug 16822: Make koha-common call koha-plack without --quiet This patch removes the --quiet option switch in koha-common.init so problem information is not hidden for sysadmin users. To test: - Have plack enabled for a koha instance: $ sudo koha-plack --enable kohadev $ sudo koha-plack --start kohadev - Run: $ cd kohaclone $ debian/koha-common.init {start|stop|restart} => SUCCESS: No behaviour change - Disable the 'cgi' apache module: $ sudo a2dismod cgi - Run: $ debian/koha-common.init {start|stop|restart} => FAIL: No warning is shown - Apply the patch - Run: $ debian/koha-common.init {start|stop|restart} => SUCCESS: Warnings show up - Sign off :-D
Created attachment 55389 [details] [review] Bug 16822: Make koha-common call koha-plack without --quiet This patch removes the --quiet option switch in koha-common.init so problem information is not hidden for sysadmin users. To test: - Have plack enabled for a koha instance: $ sudo koha-plack --enable kohadev $ sudo koha-plack --start kohadev - Run: $ cd kohaclone $ debian/koha-common.init {start|stop|restart} => SUCCESS: No behaviour change - Disable the 'cgi' apache module: $ sudo a2dismod cgi - Run: $ debian/koha-common.init {start|stop|restart} => FAIL: No warning is shown - Apply the patch - Run: $ debian/koha-common.init {start|stop|restart} => SUCCESS: Warnings show up - Sign off :-D Signed-off-by: Liz Rea <liz@catalyst.net.nz> Perfect thanks :)
Created attachment 55395 [details] [review] Bug 16822: Make koha-common call koha-plack without --quiet This patch removes the --quiet option switch in koha-common.init so problem information is not hidden for sysadmin users. To test: - Have plack enabled for a koha instance: $ sudo koha-plack --enable kohadev $ sudo koha-plack --start kohadev - Run: $ cd kohaclone $ debian/koha-common.init {start|stop|restart} => SUCCESS: No behaviour change - Disable the 'cgi' apache module: $ sudo a2dismod cgi - Run: $ debian/koha-common.init {start|stop|restart} => FAIL: No warning is shown - Apply the patch - Run: $ debian/koha-common.init {start|stop|restart} => SUCCESS: Warnings show up - Sign off :-D Signed-off-by: Liz Rea <liz@catalyst.net.nz> Perfect thanks :) Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Pushed to master for 16.11, thanks Tomas!
Pushed in 16.05. Will be in 16.05.04.
Pushed to 3.22.x, will be in 3.22.11