The logic to display messages is broken in koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt To verify, examin code in line 295 and following: [% IF ( expiry || diffbranch ) %] This hides messages after line 301: [% IF restricted %] ...and after line 304: [% IF amount_outstanding && Koha.Preference('maxoutstanding') && amount_outstanding > Koha.Preference('maxoutstanding') %]
Created attachment 53102 [details] [review] Bug 16854: request.tt: Logic to display messages broken This patch fixes broken logic in koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt To verify, see initial comment. To test: - Apply patch - Have a patron with a restricion and with outstanding fines greater than defined in syspref 'maxoutstanding' - Place a hold for this patron and verify, that messages 'Patron has restrictions' and 'Patron has outstanding fines...' appear
Created attachment 53106 [details] [review] [SIGNED-OFF]Bug 16854: request.tt: Logic to display messages broken This patch fixes broken logic in koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt To verify, see initial comment. To test: - Apply patch - Have a patron with a restricion and with outstanding fines greater than defined in syspref 'maxoutstanding' - Place a hold for this patron and verify, that messages 'Patron has restrictions' and 'Patron has outstanding fines...' appear Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Created attachment 53127 [details] [review] Bug 16854: request.tt: Logic to display messages broken This patch fixes broken logic in koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt To verify, see initial comment. To test: - Apply patch - Have a patron with a restricion and with outstanding fines greater than defined in syspref 'maxoutstanding' - Place a hold for this patron and verify, that messages 'Patron has restrictions' and 'Patron has outstanding fines...' appear Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed to master for 16.11, thanks Marc!
Pushed in 16.05. Will be in 16.05.02.
Patch pushed to 3.22.x, will be in 3.22.10