Created attachment 53208 [details] [review] Bug 16874: Making serials collections actions buttons To test: 1) Go to serials -> Search a subscription (or make a new one) 2) Ensure that subscription has an end-date that has passed or will pass soon 3) Go to Serials collection (left sidebar menu) 4) Ensure that Subscription summary table has two buttons, Create routing list and Renew. These buttons should be bolded and the table cell highlighted 5) Ensure 'Print list' is a button in year tables below 6) Edit subscription to have a later end-date (will not expire soon) 7) Go bacl to serials collection 8) Ensure that table cell is no longer highlighted and buttons not bolded. Renew button should not be there. Sponsored-by: Catalyst IT
Created attachment 53543 [details] [review] Bug 16874: Making serials collections actions buttons To test: 1) Go to serials -> Search a subscription (or make a new one) 2) Ensure that subscription has an end-date that has passed or will pass soon 3) Go to Serials collection (left sidebar menu) 4) Ensure that Subscription summary table has two buttons, Create routing list and Renew. These buttons should be bolded and the table cell highlighted 5) Ensure 'Print list' is a button in year tables below 6) Edit subscription to have a later end-date (will not expire soon) 7) Go back to serials collection 8) Ensure that table cell is no longer highlighted and buttons not bolded. Renew button should not be there. 9) Ensure that both buttons do not wrap when the browser is narrow Sponsored-by: Catalyst IT
Hi, Sorry, I didn't get two buttons in step 4 of the test. Just the one for 'create routing list'. The line wasn't highlighted either. 'Print list' was displaying just fine as a button. Claire
(In reply to Claire Gravely from comment #3) > Hi, > Sorry, I didn't get two buttons in step 4 of the test. Just the one for > 'create routing list'. The line wasn't highlighted either. > > 'Print list' was displaying just fine as a button. > > Claire Sorry, I should've added that the Renew button and row highlighting will only show if the subscription is about to expire or has expired. Could you please retest?
(In reply to Aleisha Amohia from comment #4) > (In reply to Claire Gravely from comment #3) > > Hi, > > Sorry, I didn't get two buttons in step 4 of the test. Just the one for > > 'create routing list'. The line wasn't highlighted either. > > > > 'Print list' was displaying just fine as a button. > > > > Claire > > Sorry, I should've added that the Renew button and row highlighting will > only show if the subscription is about to expire or has expired. Could you > please retest? Hi, I just tried again. Same result. I set the expiration date in the past, today and in the future and saw the same results each time with no renew button.
(In reply to Claire Gravely from comment #5) > Hi, I just tried again. Same result. I set the expiration date in the past, > today and in the future and saw the same results each time with no renew > button. Actually, I just realised that this functionality kind of doesn't work without the patch applied also. The way I describe what to expect in the test case is exactly how it should work with and without the patch, but even without it it's not acting as it should.
Hello, I tried to test this patch with the sandbox system, but it does not work. I've got this log in message in which the test/test credentials don't apply. "Welcome to the Koha web installer Before we begin, please verify you have the correct credentials to continue. Please log in with the username and password given to you by your systems administrator and located in your koha-conf.xml configuration file. Please enter your username and password:" Kind regards Aliki
Hi Aliki, could you try again with another sandbox? Make sure you try with a selected test database, to avoid the web installer if possible.
Patch tested with a sandbox, by Lisette Scheer <lisetteslatah@gmail.com>
Created attachment 54946 [details] [review] Bug 16874: Making serials collections actions buttons To test: 1) Go to serials -> Search a subscription (or make a new one) 2) Ensure that subscription has an end-date that has passed or will pass soon 3) Go to Serials collection (left sidebar menu) 4) Ensure that Subscription summary table has two buttons, Create routing list and Renew. These buttons should be bolded and the table cell highlighted 5) Ensure 'Print list' is a button in year tables below 6) Edit subscription to have a later end-date (will not expire soon) 7) Go back to serials collection 8) Ensure that table cell is no longer highlighted and buttons not bolded. Renew button should not be there. 9) Ensure that both buttons do not wrap when the browser is narrow Sponsored-by: Catalyst IT Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com>
Created attachment 54961 [details] [review] [PASSED QA] Bug 16874: Making serials collections actions buttons To test: 1) Go to serials -> Search a subscription (or make a new one) 2) Ensure that subscription has an end-date that has passed or will pass soon 3) Go to Serials collection (left sidebar menu) 4) Ensure that Subscription summary table has two buttons, Create routing list and Renew. These buttons should be bolded and the table cell highlighted 5) Ensure 'Print list' is a button in year tables below 6) Edit subscription to have a later end-date (will not expire soon) 7) Go back to serials collection 8) Ensure that table cell is no longer highlighted and buttons not bolded. Renew button should not be there. 9) Ensure that both buttons do not wrap when the browser is narrow Sponsored-by: Catalyst IT Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Pushed to master for 16.11, thanks Aleisha!