Add Font Awesome Icons to: - "Select/Clear all" links to pay.tt (Pay fines tab) - "Filter icon" in "filter paid transactions" to Accout tab (boraccount.tt) - "Trash icon" to Remove option in "Manual restrictions" (borrower_debarments.inc) also add "Ban and plus icon" to "Add manual restriction"
Created attachment 53230 [details] [review] Bug 16888: Add Font Awesome Icons to Members Add Font Awesome Icons to: - "Select/Clear all" links to pay.tt (Pay fines tab) - "Filter icon" in "filter paid transactions" to Accout tab (boraccount.tt) - "Trash icon" to Remove option in "Manual restrictions" (borrower_debarments.inc) also add "Ban and plus icon" to "Add manual restriction" To test: -Apply patch -Select a patron who has fines -Go to "Fines->Pay fines" tabs and see the icons in "Select/Clear all" -Choose the "Account" tab and sse the icon in "Filter paid transactions" -Select the "Check out" tab and go to "Restrictions" -Add a manual restriction and notice about the two new icons fa-plus and fa-band -See the new button btn-mini and the fa-trash icon -Verify that all works as expected
Created attachment 53231 [details] [review] Bug 16888: Add Font Awesome Icons to Members Add Font Awesome Icons to: - "Select/Clear all" links to pay.tt (Pay fines tab) - "Filter icon" in "filter paid transactions" to Accout tab (boraccount.tt) - "Trash icon" to Remove option in "Manual restrictions" (borrower_debarments.inc) also add "Ban and plus icon" to "Add manual restriction" To test: -Apply patch -Select a patron who has fines -Go to "Fines->Pay fines" tabs and see the icons in "Select/Clear all" -Choose the "Account" tab and sse the icon in "Filter paid transactions" -Select the "Check out" tab and go to "Restrictions" -Add a manual restriction and notice about the two new icons fa-plus and fa-band -See the new button btn-mini and the fa-trash icon -Verify that all works as expected
Created attachment 53250 [details] [review] Bug 16888: Add Font Awesome Icons to Members Add Font Awesome Icons to: - "Select/Clear all" links to pay.tt (Pay fines tab) - "Filter icon" in "filter paid transactions" to Accout tab (boraccount.tt) - "Trash icon" to Remove option in "Manual restrictions" (borrower_debarments.inc) also add "Ban and plus icon" to "Add manual restriction" To test: -Apply patch -Select a patron who has fines -Go to "Fines->Pay fines" tabs and see the icons in "Select/Clear all" -Choose the "Account" tab and sse the icon in "Filter paid transactions" -Select the "Check out" tab and go to "Restrictions" -Add a manual restriction and notice about the two new icons fa-plus and fa-band -See the new button btn-mini and the fa-trash icon -Verify that all works as expected Signed-off-by: Marc Véron <veron@veron.ch>
I think the addition of the "fa-ban" icon is unnecessary. At this time we use icons for actions (links, buttons), but not as decoration for other page elements.
Created attachment 53266 [details] [review] Bug 16888: (follow-up)Add Font Awesome Icons to Members Remove fa-ban according with QA comment 4
Keep signed-off since just removed a icon decoration
Owen, could you take a last look here if this is ok?
Created attachment 53281 [details] [review] [PASSED QA] Bug 16888: Add Font Awesome Icons to Members Add Font Awesome Icons to: - "Select/Clear all" links to pay.tt (Pay fines tab) - "Filter icon" in "filter paid transactions" to Accout tab (boraccount.tt) - "Trash icon" to Remove option in "Manual restrictions" (borrower_debarments.inc) also add "Ban and plus icon" to "Add manual restriction" To test: -Apply patch -Select a patron who has fines -Go to "Fines->Pay fines" tabs and see the icons in "Select/Clear all" -Choose the "Account" tab and sse the icon in "Filter paid transactions" -Select the "Check out" tab and go to "Restrictions" -Add a manual restriction and notice about the two new icons fa-plus and fa-band -See the new button btn-mini and the fa-trash icon -Verify that all works as expected Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 53282 [details] [review] [PASSED QA] Bug 16888: (follow-up)Add Font Awesome Icons to Members Remove fa-ban according with QA comment 4 Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 16.11, thanks Hector!
Pushed in 16.05. Will be in 16.05.02.
Patches pushed to 3.22.x, will be in 3.22.10