Created attachment 53249 [details] [review] Bug 16891: Move C4::Members::MoveMemberToDeleted to Koha::Patron->move_to_deleted This patch removes the C4::Members::MoveMemberToDeleted subroutine in order to replace it with the Koha::Patron->move_to_deleted method. Next after this change, we will move C4::Members::HandleDelBorrower and C4::Members::DelMember to the same module to simplify the code in members/deletemem.pl and misc/cronjobs/delete_patrons.pl Test plan: 1/ Delete a patron from the staff interface and make sure (s)he has been moved to the deletedborrowers table. 2/ Use the "Batch patron deletion" tool (tools/cleanborrowers.pl) to remove patron. Make sure the "Permanently delete these patrons" and "Move these patrons to the trash" options work as before 3/ Same as previously but using the cronjob misc/cronjobs/delete_patrons.pl.
Created attachment 53522 [details] [review] Bug 16891: Move C4::Members::MoveMemberToDeleted to Koha::Patron->move_to_deleted This patch removes the C4::Members::MoveMemberToDeleted subroutine in order to replace it with the Koha::Patron->move_to_deleted method. Next after this change, we will move C4::Members::HandleDelBorrower and C4::Members::DelMember to the same module to simplify the code in members/deletemem.pl and misc/cronjobs/delete_patrons.pl Test plan: 1/ Delete a patron from the staff interface and make sure (s)he has been moved to the deletedborrowers table. 2/ Use the "Batch patron deletion" tool (tools/cleanborrowers.pl) to remove patron. Make sure the "Permanently delete these patrons" and "Move these patrons to the trash" options work as before 3/ Same as previously but using the cronjob misc/cronjobs/delete_patrons.pl.
(In reply to Jonathan Druart from comment #2) > 3/ Same as previously but using the cronjob > misc/cronjobs/delete_patrons.pl. At this step I'm getting "No method move_to_deleted! at misc/cronjobs/delete_patrons.pl line 77."
Created attachment 54178 [details] [review] Bug 16891: Move C4::Members::MoveMemberToDeleted to Koha::Patron->move_to_deleted This patch removes the C4::Members::MoveMemberToDeleted subroutine in order to replace it with the Koha::Patron->move_to_deleted method. Next after this change, we will move C4::Members::HandleDelBorrower and C4::Members::DelMember to the same module to simplify the code in members/deletemem.pl and misc/cronjobs/delete_patrons.pl Test plan: 1/ Delete a patron from the staff interface and make sure (s)he has been moved to the deletedborrowers table. 2/ Use the "Batch patron deletion" tool (tools/cleanborrowers.pl) to remove patron. Make sure the "Permanently delete these patrons" and "Move these patrons to the trash" options work as before 3/ Same as previously but using the cronjob misc/cronjobs/delete_patrons.pl. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Tested the delete_patrons.pl script and cleanborrowers.pl too. Tests (are relevant and) pass and the qa scripts are happy too :-D
(In reply to Owen Leonard from comment #3) > (In reply to Jonathan Druart from comment #2) > > 3/ Same as previously but using the cronjob > > misc/cronjobs/delete_patrons.pl. > > At this step I'm getting "No method move_to_deleted! at > misc/cronjobs/delete_patrons.pl line 77." The patch has been signed off in the meanwhile. Could you confirm that it correctly works please? I have just retested and the cronjob script seems to work as expected.
(In reply to Jonathan Druart from comment #5) > Could you confirm that it correctly works please? > I have just retested and the cronjob script seems to work as expected. I defer to Tomás on the signoff, since I'm never confident that errors like that aren't a configuration problem with my gitified package installation. However, if there is more I can do to test I would be happy to do so.
Created attachment 56339 [details] [review] Bug 16891: Move C4::Members::MoveMemberToDeleted to Koha::Patron->move_to_deleted This patch removes the C4::Members::MoveMemberToDeleted subroutine in order to replace it with the Koha::Patron->move_to_deleted method. Next after this change, we will move C4::Members::HandleDelBorrower and C4::Members::DelMember to the same module to simplify the code in members/deletemem.pl and misc/cronjobs/delete_patrons.pl Test plan: 1/ Delete a patron from the staff interface and make sure (s)he has been moved to the deletedborrowers table. 2/ Use the "Batch patron deletion" tool (tools/cleanborrowers.pl) to remove patron. Make sure the "Permanently delete these patrons" and "Move these patrons to the trash" options work as before 3/ Same as previously but using the cronjob misc/cronjobs/delete_patrons.pl. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Tested the delete_patrons.pl script and cleanborrowers.pl too. Tests (are relevant and) pass and the qa scripts are happy too :-D
Created attachment 56415 [details] [review] [PASSED QA] Bug 16891: Move C4::Members::MoveMemberToDeleted to Koha::Patron->move_to_deleted This patch removes the C4::Members::MoveMemberToDeleted subroutine in order to replace it with the Koha::Patron->move_to_deleted method. Next after this change, we will move C4::Members::HandleDelBorrower and C4::Members::DelMember to the same module to simplify the code in members/deletemem.pl and misc/cronjobs/delete_patrons.pl Test plan: 1/ Delete a patron from the staff interface and make sure (s)he has been moved to the deletedborrowers table. 2/ Use the "Batch patron deletion" tool (tools/cleanborrowers.pl) to remove patron. Make sure the "Permanently delete these patrons" and "Move these patrons to the trash" options work as before 3/ Same as previously but using the cronjob misc/cronjobs/delete_patrons.pl. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Tested the delete_patrons.pl script and cleanborrowers.pl too. Tests (are relevant and) pass and the qa scripts are happy too :-D Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 56418 [details] [review] Bug 16891: Move C4::Members::MoveMemberToDeleted to Koha::Patron->move_to_deleted This patch removes the C4::Members::MoveMemberToDeleted subroutine in order to replace it with the Koha::Patron->move_to_deleted method. Next after this change, we will move C4::Members::HandleDelBorrower and C4::Members::DelMember to the same module to simplify the code in members/deletemem.pl and misc/cronjobs/delete_patrons.pl Test plan: 1/ Delete a patron from the staff interface and make sure (s)he has been moved to the deletedborrowers table. 2/ Use the "Batch patron deletion" tool (tools/cleanborrowers.pl) to remove patron. Make sure the "Permanently delete these patrons" and "Move these patrons to the trash" options work as before 3/ Same as previously but using the cronjob misc/cronjobs/delete_patrons.pl. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Tested the delete_patrons.pl script and cleanborrowers.pl too. Tests (are relevant and) pass and the qa scripts are happy too :-D Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Pushed to master for 16.11, thanks Jonathan!
Enhancement, skipping for 16.05.x