This subroutine is only used in one script and its job is the same as GetAuthorisedValueByCode. It's better to use the AuthorisedValues TT plugin to retrieve descriptions.
Created attachment 53330 [details] [review] Bug 16908: Koha::Patrons - Remove GetSortDetails This subroutine was only used in one script and its job is the same as GetAuthorisedValueByCode. It's better to use the AuthorisedValues TT plugin to retrieve AV descriptions. Test plan: Edit a patron with sort1 and/or sort2 defined. On the patron details page (members/moremember.pl) you should see the sort1 and/or sort2 info displayed.
Created attachment 53474 [details] [review] [SIGNED-OFF] Bug 16908: Koha::Patrons - Remove GetSortDetails This subroutine was only used in one script and its job is the same as GetAuthorisedValueByCode. It's better to use the AuthorisedValues TT plugin to retrieve AV descriptions. Test plan: Edit a patron with sort1 and/or sort2 defined. On the patron details page (members/moremember.pl) you should see the sort1 and/or sort2 info displayed. Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 55112 [details] [review] Bug 16908: Koha::Patrons - Remove GetSortDetails This subroutine was only used in one script and its job is the same as GetAuthorisedValueByCode. It's better to use the AuthorisedValues TT plugin to retrieve AV descriptions. Test plan: Edit a patron with sort1 and/or sort2 defined. On the patron details page (members/moremember.pl) you should see the sort1 and/or sort2 info displayed. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Pushed to master for 16.11, thanks Jonathan!
Created attachment 57268 [details] [review] Bug 16908: Remove non-desired export line GetTitles has been removed by bug 16847 and reintroduced it by bug 16908, caused by a bad merge conflict.
It seems that Marcel reintroduced a deleted line when rebasing this patch. Kyle could you push this follow-up please?