The alt-Y key which used to select Yes in circulation dialogs switches to the renew tab instead. I also noticed that the new "Don't check out and print slip (P)" button doesn't work with alt-P either.
Created attachment 54941 [details] [review] Bug 16933: Alt+y not working on "Please confirm checkout " dialogs This patch changes the keyboard shortcut for renew from Alt+y to Alt+w.
I didn't know why Alt+y was used for renew, so I changed it to Alt+w so it doesn't conflict with Alt+y to answer yes in dialogs.
Hello, You patch is not correctly formated. Please have a look at https://wiki.koha-community.org/wiki/SubmitingAPatch and then switch the status to "Needs Signoff".
Comment on attachment 54941 [details] [review] Bug 16933: Alt+y not working on "Please confirm checkout " dialogs The keyboard shortcut for renew is also set to Alt+y. Change the key for renew from Alt+y to Alt+w. To test: 1) Press Alt+y when you get a "Please confirm checkout" dialog. 2) The renew tab is selected instead of confirming the dialog. 3) Apply the patch and refresh your browser to load the change. 4) Repeat step one. 5) Alt+y confirms the checkout, Alt+w selects the renew tab.
Created attachment 55362 [details] [review] [SIGNED-OFF] Bug 16933 - Alt-Y not working on "Please confirm checkout" dialogs This patch changes the keyboard shortcut for renew from Alt+y to Alt+w. To test: 1) Press Alt+y when you get a "Please confirm checkout" dialog. 2) The renew tab is selected instead of confirming the dialog. 3) Apply the patch and refresh your browser to load the change. 4) Repeat step one. 5) Alt+y confirms the checkout, Alt+w selects the renew tab. Signed-off-by: Owen Leonard <oleonard@myacpl.org>
In order to select Yes I need to do alt+shift+y - It makes sense as it's a Y, but leaving a note anyway :)
The new shortcut for renewal should be added to the help file on the circulation home page!
Created attachment 55457 [details] [review] [PASSED QA] Bug 16933 - Alt-Y not working on "Please confirm checkout" dialogs This patch changes the keyboard shortcut for renew from Alt+y to Alt+w. To test: 1) Press Alt+y when you get a "Please confirm checkout" dialog. 2) The renew tab is selected instead of confirming the dialog. 3) Apply the patch and refresh your browser to load the change. 4) Repeat step one. 5) Alt+y confirms the checkout, Alt+w selects the renew tab. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Created attachment 56105 [details] [review] Bug 16933 - Update documentation/help file. Updates help documentation about Alt+W to open renew tab. To test: Go to circulation help page, open help file and see that new line mentioning Alt+W.
Created attachment 56114 [details] [review] Bug 16933 - Update documentation/help file. Updates help documentation about Alt+W to open renew tab. To test: Go to circulation help page, open help file and see that new line mentioning Alt+W. Signed-off-by: Jesse Maseto <jesse@bywatersolutions.com>
Created attachment 56448 [details] [review] [PASSED QA] Bug 16933 - Alt-Y not working on "Please confirm checkout" dialogs This patch changes the keyboard shortcut for renew from Alt+y to Alt+w. To test: 1) Press Alt+y when you get a "Please confirm checkout" dialog. 2) The renew tab is selected instead of confirming the dialog. 3) Apply the patch and refresh your browser to load the change. 4) Repeat step one. 5) Alt+y confirms the checkout, Alt+w selects the renew tab. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 56451 [details] [review] [PASSED QA] Bug 16933 - Update documentation/help file. Updates help documentation about Alt+W to open renew tab. To test: Go to circulation help page, open help file and see that new line mentioning Alt+W. Signed-off-by: Jesse Maseto <jesse@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
I am not sure the version setting here is correct - I tested this on master pre 16.11 release. I am resetting it.
Pushed to master for 17.05, thanks Tim, Dani!
These patches have been pushed to 16.11.x, will be in 16.11.02 .
For reference, this shortcut has been introduced by bug 12051
Pushed to 16.05.x, for 16.05.08 release