Some librarians would like to be able to add notes to deleted order lines to keep track of data such as what title the order line was for. For some reason ModOrder dies if a biblionumber is passed in, even though it does not use biblionumber and does not need it to exist in any fashion! This limitation should be removed.
Created attachment 53472 [details] [review] Bug 16934 - Cannot add notes to canceled and deleted order line Some librarians would like to be able to add notes to deleted order lines to keep track of data such as what title the order line was for. For some reason ModOrder dies if a biblionumber is passed in, even though it does not use biblionumber and does not need it to exist in any fashion! This limitation should be removed. Test Plan: 1) Create a basket with an orderline 2) Cancel the order / delete the record 3) Click the "Add internal note" link for that order line 4) Fill in a note and click "Save" 5) Note the error 6) Apply this patch 7) Repeat steps 3-4 8) Note this time the note is saved!
I may be doing something wrong, but once I've cancelled an order, the line goes grey and the option to add a note etc. is gone.
I had the same issue as Aleisha, was about to give it another go in case I was doing something odd.
My bad, the test plan should be: Test Plan: 1) Create a basket with an orderline 2) Delete the record 3) Click the "Add internal note" link for that order line 4) Fill in a note and click "Save" 5) Note the error 6) Apply this patch 7) Repeat steps 3-4 8) Note this time the note is saved! The situation arises when the record is deleted but the order is not canceled. I also wonder why we are preventing librarian's from adding notes to a canceled order. It seems like a useful feature. Outside the scope of this bug report though. Once this bug is fixed I'll probably submit a new enhancement for that.
Created attachment 53537 [details] [review] Bug 16934 - Cannot add notes to canceled and deleted order line Some librarians would like to be able to add notes to deleted order lines to keep track of data such as what title the order line was for. For some reason ModOrder dies if a biblionumber is passed in, even though it does not use biblionumber and does not need it to exist in any fashion! This limitation should be removed. Test Plan: 1) Create a basket with an orderline 2) Cancel the order / delete the record 3) Click the "Add internal note" link for that order line 4) Fill in a note and click "Save" 5) Note the error 6) Apply this patch 7) Repeat steps 3-4 8) Note this time the note is saved! Signed-off-by: Claire Gravely <c.gravely@arts.ac.uk>
Created attachment 53598 [details] [review] Bug 16934 - Cannot add notes to canceled and deleted order line Some librarians would like to be able to add notes to deleted order lines to keep track of data such as what title the order line was for. For some reason ModOrder dies if a biblionumber is passed in, even though it does not use biblionumber and does not need it to exist in any fashion! This limitation should be removed. Test Plan: 1) Create a basket with an orderline 2) Cancel the order / delete the record 3) Click the "Add internal note" link for that order line 4) Fill in a note and click "Save" 5) Note the error 6) Apply this patch 7) Repeat steps 3-4 8) Note this time the note is saved! Signed-off-by: Claire Gravely <c.gravely@arts.ac.uk> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 53599 [details] [review] Bug 16934: Add test for ModOrder Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed to master for 16.11, thanks for the followup Jonathan!
Pushed in 16.05. Will be in 16.05.02.
Patches pushed to 3.22.x, will be in 3.22.10