When I pull up items in the item search and arrange by title, publication year, publisher, itemcallnumber, etc. I am getting results that don't seem to make any sense. I am seeing reports of this in 3.22.8 as well The order seems to be the same no matter what column, and it almost appears as if they are being ordered by date accessioned
This seems to be a regression from 3.18, as we were able to sort on call numbers before.
Yes, I am pretty sure too that this worked in 3.18 - as a regression I am upping severity a bit.
Created attachment 58243 [details] [review] Bug 16951: Fix Item search sorting Caused by commit ac5a1bfececb5400a77f0ebad90181f5215d5a85 Bug 16154: CGI->multi_param - Manual changes The change was wrong, we wanted to retrieve a scalar (the string), not an array. We want to retrieve a string with the different column' names, not an array of 1 element. Test plan: Launch an item search and play with column sort
Created attachment 58244 [details] [review] Bug 16951: Replace some more In order to avoid warnings in the logs, $cgi->param should be forced to scalar context
Created attachment 58381 [details] [review] Bug 16951: Fix Item search sorting Caused by commit ac5a1bfececb5400a77f0ebad90181f5215d5a85 Bug 16154: CGI->multi_param - Manual changes The change was wrong, we wanted to retrieve a scalar (the string), not an array. We want to retrieve a string with the different column' names, not an array of 1 element. Test plan: Launch an item search and play with column sort Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 58382 [details] [review] Bug 16951: Replace some more In order to avoid warnings in the logs, $cgi->param should be forced to scalar context Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 58384 [details] [review] Bug 16951: Fix Item search sorting Caused by commit ac5a1bfececb5400a77f0ebad90181f5215d5a85 Bug 16154: CGI->multi_param - Manual changes The change was wrong, we wanted to retrieve a scalar (the string), not an array. We want to retrieve a string with the different column' names, not an array of 1 element. Test plan: Launch an item search and play with column sort Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Created attachment 58385 [details] [review] Bug 16951: Replace some more In order to avoid warnings in the logs, $cgi->param should be forced to scalar context Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Pushed to master for 17.05, thanks Jonathan!
These patches have been pushed to 16.11.x, will be in 16.11.01.
Pushed to 3.22.x for 3.22.14
Pushed to 16.05.x, for 16.05.07 release