There are a few instances of "onclick" in the templates for serial patron and vendor search templates. These should be removed in favor of events defined in the JavaScript.
Created attachment 53684 [details] [review] Bug 16968 - Remove the use of "onclick" from serial patron and vendor search templates This patch removes instances of "onclick" from the serials templates for patron and vendor search. To test, go to Serials and click "New subscription." - In the new subscription form, click the "Search for a vendor" link. - In the popup, search for a vendor. Confirm that clicking "Choose" selects the correct vendor. - From the detail page of an existing subscription, click "Create routing list." - Search for a patron and test that the "Add" button in search results works correctly to add patrons to the routing list.
Created attachment 53722 [details] [review] Bug 16968 - Remove the use of "onclick" from serial patron and vendor search templates This patch removes instances of "onclick" from the serials templates for patron and vendor search. To test, go to Serials and click "New subscription." - In the new subscription form, click the "Search for a vendor" link. - In the popup, search for a vendor. Confirm that clicking "Choose" selects the correct vendor. - From the detail page of an existing subscription, click "Create routing list." - Search for a patron and test that the "Add" button in search results works correctly to add patrons to the routing list. Signed-off-by: Claire Gravely <c.gravely@arts.ac.uk>
Created attachment 53839 [details] [review] Bug 16968 - Remove the use of "onclick" from serial patron and vendor search templates This patch removes instances of "onclick" from the serials templates for patron and vendor search. To test, go to Serials and click "New subscription." - In the new subscription form, click the "Search for a vendor" link. - In the popup, search for a vendor. Confirm that clicking "Choose" selects the correct vendor. - From the detail page of an existing subscription, click "Create routing list." - Search for a patron and test that the "Add" button in search results works correctly to add patrons to the routing list. Signed-off-by: Claire Gravely <c.gravely@arts.ac.uk> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed to master for 16.11, thanks Owen!