I'm working on a patch which will remove event attributes from the following templates: catalogue/MARCdetail.tt catalogue/labeledMARCdetail.tt offline_circ/process_koc.tt reports/guided_reports_start.tt
Created attachment 54051 [details] [review] Bug 17056 - Remove event attributes from various templates This patch removes event attributes from several templates, moving event definitions into the JavaScript instead. To test, apply the patch and: - View the MARC detail page for any bibliographic record. Changing the framework selection should reload the display using the selected framework. - Perform the same test on the labeled MARC view. (Set the viewLabeledMARC system preference to "Allow" if necessary). - To test the changes to Reports you should have at least one report group and at least one report subgroup. - Create a new saved SQL report. - Select a report group. Doing so should trigger the display of report subgroups. Deselecting the report group should hide the subgroups. - In Acquisitions -> Suggestions, create a new suggestion. - In the 'Acquisition information' section, changing values for copies, currency, and price should change the value in the total field. - In Circulation -> Upload offline circulation file: - My patch for Bug 16602 added the required code but forgot to remove the corresponding onclick attributes. - Browse for an offline circulation file. - Clicking the 'Upload file' button should work correctly. - After uploading a file, both the 'Add to offline circulation queue' and 'Apply directly' buttons should work to trigger their corresponding processes (keeping Bug 16603 in mind).
This was marked as "Patch doesn't apply" but it's working fine for me. Please re-test.
Created attachment 54735 [details] [review] [SIGNED-OFF] Bug 17056 - Remove event attributes from various templates This patch removes event attributes from several templates, moving event definitions into the JavaScript instead. To test, apply the patch and: - View the MARC detail page for any bibliographic record. Changing the framework selection should reload the display using the selected framework. - Perform the same test on the labeled MARC view. (Set the viewLabeledMARC system preference to "Allow" if necessary). - To test the changes to Reports you should have at least one report group and at least one report subgroup. - Create a new saved SQL report. - Select a report group. Doing so should trigger the display of report subgroups. Deselecting the report group should hide the subgroups. - In Acquisitions -> Suggestions, create a new suggestion. - In the 'Acquisition information' section, changing values for copies, currency, and price should change the value in the total field. - In Circulation -> Upload offline circulation file: - My patch for Bug 16602 added the required code but forgot to remove the corresponding onclick attributes. - Browse for an offline circulation file. - Clicking the 'Upload file' button should work correctly. - After uploading a file, both the 'Add to offline circulation queue' and 'Apply directly' buttons should work to trigger their corresponding processes (keeping Bug 16603 in mind). Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com>
Created attachment 55661 [details] [review] [PASSED QA] Bug 17056 - Remove event attributes from various templates This patch removes event attributes from several templates, moving event definitions into the JavaScript instead. To test, apply the patch and: - View the MARC detail page for any bibliographic record. Changing the framework selection should reload the display using the selected framework. - Perform the same test on the labeled MARC view. (Set the viewLabeledMARC system preference to "Allow" if necessary). - To test the changes to Reports you should have at least one report group and at least one report subgroup. - Create a new saved SQL report. - Select a report group. Doing so should trigger the display of report subgroups. Deselecting the report group should hide the subgroups. - In Acquisitions -> Suggestions, create a new suggestion. - In the 'Acquisition information' section, changing values for copies, currency, and price should change the value in the total field. - In Circulation -> Upload offline circulation file: - My patch for Bug 16602 added the required code but forgot to remove the corresponding onclick attributes. - Browse for an offline circulation file. - Clicking the 'Upload file' button should work correctly. - After uploading a file, both the 'Add to offline circulation queue' and 'Apply directly' buttons should work to trigger their corresponding processes (keeping Bug 16603 in mind). Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Pushed to master for 16.11, thanks Owen!
Pushed in 16.05. Will be in 16.05.05.