numeric comparison operator used where string comparison required, results in following warning in the log: Argument "delete" isn't numeric in numeric eq (==) at /usr/share/koha/intranet/cgi-bin/acqui/edifactmsgs.pl line 42
Created attachment 54173 [details] [review] Proposed patch To test apply the patch and the warning should no longer appear in the error log
Created attachment 54229 [details] [review] [SIGNED-OFF] Bug 17081 Incorrect comparison operator used in edifactmsgs.pl Numeric comparison operator is used where string comparison required, resulting in the following warning in the log: 'Argument "delete" isn't numeric in numeric eq (==).' This patch corrects it to use 'eq' not '==' to compare strings. To test, apply the patch and go to Acquisitions -> EDIFACT messages. Delete an EDIFACT message. There should be no error in the error log. Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 54248 [details] [review] [PASSED QA] Bug 17081 Incorrect comparison operator used in edifactmsgs.pl Numeric comparison operator is used where string comparison required, resulting in the following warning in the log: 'Argument "delete" isn't numeric in numeric eq (==).' This patch corrects it to use 'eq' not '==' to compare strings. To test, apply the patch and go to Acquisitions -> EDIFACT messages. Delete an EDIFACT message. There should be no error in the error log. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 16.11, thanks Colin!
Pushed in 16.05. Will be in 16.05.03.