This patch will remove event attributes from some tools-related templates: labels/label-edit-layout.tt tools/cleanborrowers.tt tools/inventory.tt tools/letter.tt tools/upload.tt
Created attachment 54199 [details] [review] Bug 17083 - Remove more event attributes from tools templates This patch removes event attributes from several tool-related templates. Events are defined instead in the JavaScript. To test, apply the patch and: - Go to Tools -> Label creator -> Manage -> Layouts and edit any layout. - In the "Font" setting, choose any font which includes the word "italic" or "oblique" in the name. Doing so should disable the "Oblique title" checkbox. - Go to Tools -> Batch patron deletion/anonymization. - Submit the form without making any changes. You should be prompted to select an action. - Go to Tools -> Inventory. - Select a batch of barcodes to upload. - Submit the form without selecting any filters. This should trigger a warning. - Also changed: Added Font Awesome icons to the "Select all" and "Clear all" links on the inventory results view. - Go to Tools -> Notices and Slips. - Click "New notice" - Change the selection under "Koha module." The page should reload with the correct available message body fields. For instance, selecting "Holds" should make available reserves.* columns. - Go to Tools -> Upload. - In the search form, enter a search term and click the 'Search' button. The form should submit.
Created attachment 54244 [details] [review] [SIGNED-OFF]Bug 17083: Remove more event attributes from tools templates This patch removes event attributes from several tool-related templates. Events are defined instead in the JavaScript. To test, apply the patch and: - Go to Tools -> Label creator -> Manage -> Layouts and edit any layout. - In the "Font" setting, choose any font which includes the word "italic" or "oblique" in the name. Doing so should disable the "Oblique title" checkbox. - Go to Tools -> Batch patron deletion/anonymization. - Submit the form without making any changes. You should be prompted to select an action. - Go to Tools -> Inventory. - Select a batch of barcodes to upload. - Submit the form without selecting any filters. This should trigger a warning. - Also changed: Added Font Awesome icons to the "Select all" and "Clear all" links on the inventory results view. - Go to Tools -> Notices and Slips. - Click "New notice" - Change the selection under "Koha module." The page should reload with the correct available message body fields. For instance, selecting "Holds" should make available reserves.* columns. - Go to Tools -> Upload. - In the search form, enter a search term and click the 'Search' button. The form should submit. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised. Event attributes removed
Created attachment 54435 [details] [review] [PASSED QA] Bug 17083: Remove more event attributes from tools templates This patch removes event attributes from several tool-related templates. Events are defined instead in the JavaScript. To test, apply the patch and: - Go to Tools -> Label creator -> Manage -> Layouts and edit any layout. - In the "Font" setting, choose any font which includes the word "italic" or "oblique" in the name. Doing so should disable the "Oblique title" checkbox. - Go to Tools -> Batch patron deletion/anonymization. - Submit the form without making any changes. You should be prompted to select an action. - Go to Tools -> Inventory. - Select a batch of barcodes to upload. - Submit the form without selecting any filters. This should trigger a warning. - Also changed: Added Font Awesome icons to the "Select all" and "Clear all" links on the inventory results view. - Go to Tools -> Notices and Slips. - Click "New notice" - Change the selection under "Koha module." The page should reload with the correct available message body fields. For instance, selecting "Holds" should make available reserves.* columns. - Go to Tools -> Upload. - In the search form, enter a search term and click the 'Search' button. The form should submit. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised. Event attributes removed Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 55750 [details] [review] [PASSED QA] Bug 17083: Remove more event attributes from tools templates This patch removes event attributes from several tool-related templates. Events are defined instead in the JavaScript. To test, apply the patch and: - Go to Tools -> Label creator -> Manage -> Layouts and edit any layout. - In the "Font" setting, choose any font which includes the word "italic" or "oblique" in the name. Doing so should disable the "Oblique title" checkbox. - Go to Tools -> Batch patron deletion/anonymization. - Submit the form without making any changes. You should be prompted to select an action. - Go to Tools -> Inventory. - Select a batch of barcodes to upload. - Submit the form without selecting any filters. This should trigger a warning. - Also changed: Added Font Awesome icons to the "Select all" and "Clear all" links on the inventory results view. - Go to Tools -> Notices and Slips. - Click "New notice" - Change the selection under "Koha module." The page should reload with the correct available message body fields. For instance, selecting "Holds" should make available reserves.* columns. - Go to Tools -> Upload. - In the search form, enter a search term and click the 'Search' button. The form should submit. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised. Event attributes removed Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 16.11, thanks Owen!