For instance the 2 methods get_shares and get_contents from Koha::Virtualshelf return DBIx::Class objects instead of Koha::Virtualshelfshares and Koha::Virtualshelfcontents objects.
Created attachment 54239 [details] [review] Bug 17094: Add delete to the Koha::Objects AUTOLOAD method
Created attachment 54240 [details] [review] Bug 17094: Make Koha::Virtualshelf methods return Koha::Objects-based objects Instead of DBIx::Class objects. Test plan: 1/ Add content to a list and share it with another patron 2/ Try to view the list with the other patron 3/ download and send a shelf and check if the biblio list is correct 4/ prove t/db_dependent/Virtualshelves.t should return green
fatal: sha1 information is lacking or useless (Koha/Objects.pm).
(In reply to Aleisha Amohia from comment #3) > fatal: sha1 information is lacking or useless (Koha/Objects.pm). Did you apply all the dependencies?
Created attachment 54795 [details] [review] [SIGNED-OFF] Bug 17094: Add delete to the Koha::Objects AUTOLOAD method Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com>
Created attachment 54796 [details] [review] [SIGNED-OFF] Bug 17094: Make Koha::Virtualshelf methods return Koha::Objects-based objects Instead of DBIx::Class objects. Test plan: 1/ Add content to a list and share it with another patron 2/ Try to view the list with the other patron 3/ download and send a shelf and check if the biblio list is correct 4/ prove t/db_dependent/Virtualshelves.t should return green Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com>
Comment on attachment 54795 [details] [review] [SIGNED-OFF] Bug 17094: Add delete to the Koha::Objects AUTOLOAD method Moved to bug 17091
Created attachment 56345 [details] [review] [PASSED QA] Bug 17094: Make Koha::Virtualshelf methods return Koha::Objects-based objects Instead of DBIx::Class objects. Test plan: 1/ Add content to a list and share it with another patron 2/ Try to view the list with the other patron 3/ download and send a shelf and check if the biblio list is correct 4/ prove t/db_dependent/Virtualshelves.t should return green Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Pushed to Master - Should be in the November 16.11 Release. Thanks!