Here should be a new option for checkin message by itemtypes implemented. This new option required a confirmation from the user (over a question which is written there) bevor the item is checked in. The only possible answer for the question are yes or no. By yes the item is checked in, by no it's not checked in. To give an example what is meant here: If you create the item type audiobook, you then can add the Check in Message : "Does envelope and content match?" and for the check in message type: question. So if now a item with the item type audiobook is checked in, the user is ask : "Does envelope and content match?" and got the answer possibiltys yes and no. At this moment he can't read a new barcode, so he must answer the question. If he answer yes the item is check in, if he answer no the item is not check in.
Created attachment 54380 [details] [review] Bug 17101 - Confirm a question before check in This patch enable the checkin message type question. This type ask the user before the item is check in, yes or no. Only if he click yes then the item is checked in. Test plan: 1. Create an itemtype, with the checkinmsgtype question 2. Create an item with the itemtype from 1 3. Check out the item from 2 4. Check in the item from 3 5. Click no ==> item shouldn't be check in 6. Check in the item from 3 7. Click yes ==> item should be check in Optional: Before step 4 check others item in, to check if the prevouis check in's are still shown.
Created attachment 54381 [details] [review] Bug 17101 - Confirm a question before check in This patch enable the checkin message type question. This type ask the user before the item is check in, yes or no. Only if he click yes then the item is checked in. Test plan: 1. Create an itemtype, with the checkinmsgtype question 2. Create an item with the itemtype from 1 3. Check out the item from 2 4. Check in the item from 3 5. Click no ==> item shouldn't be check in 6. Check in the item from 3 7. Click yes ==> item should be check in Optional: Before step 4 check others item in, to check if the prevouis check in's are still shown. Sponsored-by: Bücherei Maichingen
Created attachment 54386 [details] [review] Bug 17101 - Confirm a question before check in This patch enable the checkin message type question. This type ask the user before the item is check in, yes or no. Only if he click yes then the item is checked in. Test plan: 1. Create an itemtype, with the checkinmsgtype question 2. Create an item with the itemtype from 1 3. Check out the item from 2 4. Check in the item from 3 5. Click no ==> item shouldn't be check in 6. Check in the item from 3 7. Click yes ==> item should be check in Optional: Before step 4 check others item in, to check if the prevouis check in's are still shown. Sponsored-by: Bücherei Maichingen Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net>
Followed the testplan, works for me. It would be nice to have some kind of message about not checking in the item after hitting cancel.
Created attachment 54388 [details] [review] Bug 17101 - Style up 1 This patch enable the checkin message type question. This type ask the user before the item is check in, yes or no. Only if he click yes then the item is checked in. Test plan: 1. Create an itemtype, with the checkinmsgtype question 2. Create an item with the itemtype from 1 3. Check out the item from 2 4. Check in the item from 3 5. Click no ==> item shouldn't be check in and a message should be displayed 6. Check in the item from 3 7. Click yes ==> item should be check in and a message should be displayed Optional: Before step 4 check others item in, to check if the prevouis check in's are still shown. Sponsored-by: Bücherei Maichingen
Created attachment 54389 [details] [review] Bug 17101 - Style up 2 Added a messag when an item is not checked in, becaus of answer no. (new) Test plan: 1. Create an itemtype, with the checkinmsgtype question 2. Create an item with the itemtype from 1 3. Check out the item from 2 4. Check in the item from 3 5. Click no ==> item shouldn't be check in and a message should be displayed 6. Check in the item from 3 7. Click yes ==> item should be check in Optional: Before step 4 check others item in, to check if the prevouis check in's are still shown. Sponsored-by: Bücherei Maichingen
Created attachment 54390 [details] [review] Bug 17101 - Style up This patch enable a message for the user after he hit no, by the question in the check in window (new) Test plan: 1. Create an itemtype, with the checkinmsgtype question 2. Create an item with the itemtype from 1 3. Check out the item from 2 4. Check in the item from 3 5. Click no ==> item shouldn't be check in and a message should be displ ayed 6. Check in the item from 3 7. Click yes ==> item should be check in ed Optional: Before step 4 check others item in, to check if the prevouis check in's Sponsored-by: Bücherei Maichingen
With the second patch, I see a message when the item was not checked in, but there are no messages anymore for the other options besides "Question".
Created attachment 54425 [details] [review] Bug 17101 - Style Up fix This patch enable a message for the user after he hit no, by the question in the check in window. Fixed the bug that no other message are displayed (new) Test plan: 1. Create an itemtype, with the checkinmsgtype question 2. Create an item with the itemtype from 1 3. Check out the item from 2 4. Check in the item from 3 5. Click no ==> item shouldn't be check in and a message should be displ ayed 6. Check in the item from 3 7. Click yes ==> item should be check in ed Optional: Before step 4 check others item in, to check if the prevouis check in's Sponsored-by: Bücherei Maichingen
Created attachment 54495 [details] Problem with workflow if hold found There is a problem with the workflow if a hold is found. What should users do first first, confirm hold etc. or confirm question? Confirming hold leads to an internal server error, plack error log says: Fatal: unexpected operator 'cancellationdate' with undef operand at ....Koha/Objects.pm line 1
Internal server error when confirming might be related to Bug 16942 See IRC: http://irc.koha-community.org/koha/2016-08-16#i_1849391 Regarding the work flow: It is confusing to have two things to confirm. Maybe two steps are better: First the question about checking in and only after confirming this question the qeustion about holds. What do you think about?
Added Bug 8451 as related ("Confusing and problematic double prompt for processing transfers") Setting to "In Discussion" because the whole check in process needs clarification. See: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8451#c10
Can we get this moving again? Maybe put it on the agenda of the next dev meeting?
Hey, to solve the problem with the order of the information i would suggest following solution: Only one message is shown to the user. The message with the highest priority, is shown first. When it was handeln the next massage is shown. Following priority order should be made: 1. Question 2. Holds 3. Transportation ( only if not treated by holds) Feel free to disscuss it.
Sounds good to me.
That seems like the correct order to me.
*** Bug 14525 has been marked as a duplicate of this bug. ***