In patron acount ("your personal details" tab, which serves as a form for submitting update requests as well) it's not possible to display some account details like expiration date etc., without enabling the field for branch / library update requests too. To reproduce: - set OPACPatronDetails to "Allow" - clear PatronSelfModificationBorrowerUnwantedField preference - all possible fields in the update requests form are visible in patron account, including some extra details (card number, expiration date, category) in the "Library" section on top - put 'branchcode' in PatronSelfModificationBorrowerUnwantedField preference - the whole 'Library' section disappears
Created attachment 54377 [details] [review] Bug 17117 - Patron personal details not displayed unless branch update request is enabled In patron acount ("your personal details" tab, which serves as a form for submitting update requests as well) it's not possible to display some account details like expiration date etc., without enabling the field for branch / library update requests too. To reproduce: 1) set OPACPatronDetails to "Allow" 2) clear PatronSelfModificationBorrowerUnwantedField preference - all possible fields in the update requests form are visible in patron account, including some extra details (card number, expiration date, category) in the "Library" section on top 3) put 'branchcode' in PatronSelfModificationBorrowerUnwantedField preference 4) the whole 'Library' section disappears To test: 1) apply patch 2) put 'branchcode' in PatronSelfModificationBorrowerUnwantedField, 'Library' section should remain visible (sans branch selection option) 3) put 'branchcode|cardnumber|datexpiry|categorycode' in the same preference, 'Library' section should now disappear
Created attachment 54379 [details] [review] [SIGNED-OFF]Bug 17117: Patron personal details not displayed unless branch update request is enabled In patron acount ("your personal details" tab, which serves as a form for submitting update requests as well) it's not possible to display some account details like expiration date etc., without enabling the field for branch / library update requests too. To reproduce: 1) set OPACPatronDetails to "Allow" 2) clear PatronSelfModificationBorrowerUnwantedField preference - all possible fields in the update requests form are visible in patron account, including some extra details (card number, expiration date, category) in the "Library" section on top 3) put 'branchcode' in PatronSelfModificationBorrowerUnwantedField preference 4) the whole 'Library' section disappears To test: 1) apply patch 2) put 'branchcode' in PatronSelfModificationBorrowerUnwantedField, 'Library' section should remain visible (sans branch selection option) 3) put 'branchcode|cardnumber|datexpiry|categorycode' in the same preference, 'Library' section should now disappear Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised
Created attachment 54428 [details] [review] [PASSED QA] Bug 17117: Patron personal details not displayed unless branch update request is enabled In patron acount ("your personal details" tab, which serves as a form for submitting update requests as well) it's not possible to display some account details like expiration date etc., without enabling the field for branch / library update requests too. To reproduce: 1) set OPACPatronDetails to "Allow" 2) clear PatronSelfModificationBorrowerUnwantedField preference - all possible fields in the update requests form are visible in patron account, including some extra details (card number, expiration date, category) in the "Library" section on top 3) put 'branchcode' in PatronSelfModificationBorrowerUnwantedField preference 4) the whole 'Library' section disappears To test: 1) apply patch 2) put 'branchcode' in PatronSelfModificationBorrowerUnwantedField, 'Library' section should remain visible (sans branch selection option) 3) put 'branchcode|cardnumber|datexpiry|categorycode' in the same preference, 'Library' section should now disappear Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 16.11, thanks Jacek!
Pushed in 16.05. Will be in 16.05.03.
Pushed to 3.22.x, will be in 3.22.10