When a patron logs in the OPAC on any page, except opac-reserve.pl, they are always redirected to opac-user.pl. This can prove to be problematic in regards to tasks such as navigating search results (including both catalog and EDS searches if the EDS plugin is installed), adding tags, adding comments, or nearly any other action which requires a patron to login.
Created attachment 54657 [details] [review] Forces redirect to search results after logging in on opac-search.pl To test: - Perform a catalog or EDS search - Login from opac-search.pl - Without the patch, the page should redirect to opac-user.pl - Log out - Apply patch - Perform a search again - Login again from opac-search.pl - The page should redirect back to search results
Sorry, while applying I get: "fatal: sha1 information is lacking or useless (opac/opac-user.pl)" Can not fall back to 3-way-merge because of missing Blobs.
Sorry about that, Marc! I'm uploading an updated patch now which should correct that fatality.
Created attachment 54715 [details] [review] Bug 17153: Fixed Fail Fail This updated patch should correct fatal error when applying 54657. Forces redirect to search results after logging in on opac-search.pl To test: - Perform a catalog or EDS search - Login from opac-search.pl - Without the patch, the page should redirect to opac-user.pl - Log out - Apply patch - Perform a search again - Login again from opac-search.pl - The page should redirect back to search results
Created attachment 54719 [details] [review] [SIGNED-OFF] Bug 17153: Logging in during a search should navigate back to search results Forces redirect to search results after logging in on opac-search.pl To test: - Perform a catalog or EDS search - Login from opac-search.pl - Without the patch, the page should redirect to opac-user.pl - Log out - Apply patch - Perform a search again - Login again from opac-search.pl - The page should redirect back to search results Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com>
Hi Lee, eds-search.pl is not part of Koha and this part of the patch should be removed I'd say.
Created attachment 54782 [details] [review] Bug 17153: Simplified redirect To test: - Perform a catalog search - Login from opac-search.pl - Without the patch, the page should redirect to opac-user.pl - Log out - Apply patch - Perform a search again - Login again from opac-search.pl - The page should redirect back to search results
This works for me, but the QA tools warn that the changes to Output.pm introduce tab characters. Indentation should be 4 spaces: https://wiki.koha-community.org/wiki/Coding_Guidelines#PERL6:_Indentation When you modify your patch, please use the bug report title as the commit message's first line: "Bug 17153 - Logging in during a search navigates to account page instead of back to search results" ...and include test plan in your commit message as well. Thanks!
Owen, Thank you for the constructive criticism! This was my very first attempt at a bug report so I'm still learning. I made a note to myself to make your suggestions a habit from now on! I'll make necessary changes then re-submit. For my own knowledge, when I upload the update, should I put the status to Needs Signoff? Or Signed Off? Thanks!
(In reply to Lee Jamison from comment #9) > For my own knowledge, when I upload the update, should I put the status to > Needs Signoff? Or Signed Off? Thanks! Set the status back to "needs signoff" so that everyone knows it is ready for testing again.
Created attachment 57549 [details] [review] Bug 17153 - Add logic to pass URL to output so redirct to search results can occur
Created attachment 57550 [details] [review] Bug 17153 - Add logic to pass URL to output so redirct to search results can occur
I would love to see this bug fixed. It's quite annoying to lose your context and having to search again for the book you were about to tag/comment etc. When no longer being taken to opac-user.pl when logging in it will be less obvious for end users how to get to their account. Hence the tagging of 2093 as a "see also".
Kyle, is this patch ready for signoff?
There is a small conflict, can you please rebase? Applying: Bug 17153 - Add logic to pass URL to output so redirct to search results can occur Using index info to reconstruct a base tree... M C4/Output.pm M opac/opac-search.pl M opac/opac-user.pl Falling back to patching base and 3-way merge... Auto-merging opac/opac-user.pl CONFLICT (content): Merge conflict in opac/opac-user.pl Auto-merging opac/opac-search.pl Auto-merging C4/Output.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 17153 - Add logic to pass URL to output so redirct to search results can occur The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-17153---Add-logic-to-pass-URL-to-output-so-red-YH0gjy.patch
Created attachment 75714 [details] [review] Bug 17153: Login during search rebase and fix This patch is a fresh attempt at redirecting back to search results after logging in on opac-search.pl To test: - Perform an OPAC search - Login on opac-search.pl with the search results displayed - The page is redirected to opac-user.pl - Log out - Apply the patch - Perform a new OPAC search - Note the URL query string - Login on opac-search.pl with the search results displayed - The opac-search.pl page should be displayed with the correct query string and the page should indicate a logged in status
Hi Maryse, did you mean to sign off on this patch? I see that you changed the status. Did you test and can you add your sign-off line to the patch plz?
Created attachment 75933 [details] [review] Bug 17153: Login during search rebase and fix This patch is a fresh attempt at redirecting back to search results after logging in on opac-search.pl To test: - Perform an OPAC search - Login on opac-search.pl with the search results displayed - The page is redirected to opac-user.pl - Log out - Apply the patch - Perform a new OPAC search - Note the URL query string - Login on opac-search.pl with the search results displayed - The opac-search.pl page should be displayed with the correct query string and the page should indicate a logged in status Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Followed the test plan and the patch works.
Created attachment 76429 [details] [review] Bug 17153: Login during search rebase and fix This patch is a fresh attempt at redirecting back to search results after logging in on opac-search.pl To test: - Perform an OPAC search - Login on opac-search.pl with the search results displayed - The page is redirected to opac-user.pl - Log out - Apply the patch - Perform a new OPAC search - Note the URL query string - Login on opac-search.pl with the search results displayed - The opac-search.pl page should be displayed with the correct query string and the page should indicate a logged in status Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Followed the test plan and the patch works. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 76430 [details] [review] Bug 17153: Redirect to search when logging in from search This patch is a fresh attempt at redirecting back to search results after logging in on opac-search.pl To test: - Perform an OPAC search - Login on opac-search.pl with the search results displayed - The page is redirected to opac-user.pl - Log out - Apply the patch - Perform a new OPAC search - Note the URL query string - Login on opac-search.pl with the search results displayed - The opac-search.pl page should be displayed with the correct query string and the page should indicate a logged in status Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Followed the test plan and the patch works. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Please always describe your change in your subject line :)
Awesome work all! Pushed to master for 18.11
Enhancement, changes behaviour, not backporting for 18.05.x series.