Bug 16341 moved caching for marc subfield structure to Koha:::Cache and removed the global variable C4::Context->marcfromkohafield. Two scripts with calls for this variable remain in the code: t/db_dependent/Search.t and Koha/MetadataRecord.pm
Created attachment 54922 [details] [review] Bug 17201: (bug 16431 follow-up) Remove occurrence of marcfromkohafield I am not sure this code is called so I don't know how to test it.
Created attachment 54923 [details] [review] Bug 17201: (bug 16431 follow-up2) Remove occurrence of marcfromkohafield I really don't know how these tests passed before 16431, the mapping was not complete. Test plan: prove t/db_dependent/Search.t should return green
Second patch will fix the Search.t tests and make Jenkins happy!
Tests work! Huzzah! For MetadataRecord.pm: 1 - you need to use or specify namespace for GetMarcSubfieldStructure 2 - my ($tag, $subfield) = @$tagfield; doesn't work
Created attachment 54926 [details] [review] Bug 17201: (bug 16431 follow-up) Remove occurrence of marcfromkohafield I am not sure this code is called so I don't know how to test it.
Created attachment 54927 [details] [review] Bug 17201: (bug 16431 follow-up2) Remove occurrence of marcfromkohafield I really don't know how these tests passed before 16431, the mapping was not complete. Test plan: prove t/db_dependent/Search.t should return green
Created attachment 54930 [details] [review] Bug 17201: (bug 16431 follow-up) Remove occurrence of marcfromkohafield I am not sure this code is called so I don't know how to test it. Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Created attachment 54931 [details] [review] Bug 17201: (bug 16431 follow-up2) Remove occurrence of marcfromkohafield I really don't know how these tests passed before 16431, the mapping was not complete. Test plan: prove t/db_dependent/Search.t should return green Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
To test: Disable plack (bug 17204) Open advanced cataloging editor Perform a Z39.50 search Internal Search Error Apply patch Reload Perform a Z39.50 search Success
Created attachment 54958 [details] [review] [PASSED QA] Bug 17201: (bug 16431 follow-up) Remove occurrence of marcfromkohafield I am not sure this code is called so I don't know how to test it. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Created attachment 54959 [details] [review] [PASSED QA] Bug 17201: (bug 16431 follow-up2) Remove occurrence of marcfromkohafield I really don't know how these tests passed before 16431, the mapping was not complete. Test plan: prove t/db_dependent/Search.t should return green Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Created attachment 54986 [details] [review] [PASSED QA] Bug 17201: (bug 16431 follow-up2) Remove occurrence of marcfromkohafield I really don't know how these tests passed before 16431, the mapping was not complete. Test plan: prove t/db_dependent/Search.t should return green Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Fixed commit author name
Pushed to master for 16.11, thanks Jonathan!
Needed for 16.05.x
Pushed in 16.05. Will be in 16.05.04.