Created attachment 54966 [details] [review] Bug 17209: Remove use of onclick from masthead There are two instances which use onclick in the OPAC masthead: clearing search history, and logging out. To test: Confirm that clearing search history using the 'x' in the masthead, and logging out by clicking 'Log out' in the masthead, work the same before and after the patch. Sponsored-by: Catalyst IT
Created attachment 54974 [details] [review] [SIGNED-OFF] Bug 17209: Remove use of onclick from masthead There are two instances which use onclick in the OPAC masthead: clearing search history, and logging out. To test: Confirm that clearing search history using the 'x' in the masthead, and logging out by clicking 'Log out' in the masthead, work the same before and after the patch. Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment on attachment 54974 [details] [review] [SIGNED-OFF] Bug 17209: Remove use of onclick from masthead Review of attachment 54974 [details] [review]: ----------------------------------------------------------------- ::: koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc @@ +237,4 @@ > } > }); > > + $(".persona").on("click",function(){ Why don't you use the existing id node (logout) to catch it instead of adding a new class?
Created attachment 55592 [details] [review] Bug 17209: Remove use of onclick from masthead There are two instances which use onclick in the OPAC masthead: clearing search history, and logging out. To test: Confirm that clearing search history using the 'x' in the masthead, and logging out by clicking 'Log out' in the masthead, work the same before and after the patch. Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Sorry, I get a merge conflict in koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc
Created attachment 57875 [details] [review] Bug 17209: Remove use of onclick from masthead There are two instances which use onclick in the OPAC masthead: clearing search history, and logging out. To test: Confirm that clearing search history using the 'x' in the masthead, and logging out by clicking 'Log out' in the masthead, work the same before and after the patch. Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Merge conflict fixed, ready to test
Created attachment 58238 [details] [review] Bug 17209: Remove use of onclick from masthead There are two instances which use onclick in the OPAC masthead: clearing search history, and logging out. To test: Confirm that clearing search history using the 'x' in the masthead, and logging out by clicking 'Log out' in the masthead, work the same before and after the patch. Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Marc Véron <veron@veron.ch>
Created attachment 58455 [details] [review] Bug 17209: Remove use of onclick from masthead There are two instances which use onclick in the OPAC masthead: clearing search history, and logging out. To test: Confirm that clearing search history using the 'x' in the masthead, and logging out by clicking 'Log out' in the masthead, work the same before and after the patch. Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Pushed to master for 17.05, thanks Aleisha!
This won't get ported back to 16.11.x as it is an enhancement.