Created attachment 55189 [details] [review] Bug 17253: Koha::AuthorisedValues - Remove GetKohaAuthorisedValues This patch replaces the call to C4::Koha::GetKohaAuthorisedValues with Koha::AuthorisedValues->search_by_koha_field Test plan: AV descriptions should be displayed on the following pages: - XSLT view - location and ccode - Bibliographic detail, moredetail and OPAC pages - location, ccode, copynumber - returns - location - opac-basket - ccode, location - The 3 reports: catalogue_stats.pl, issues_stats.pl and reserves_stats.pl - location, ccode
Created attachment 55520 [details] [review] Bug 17253: Koha::AuthorisedValues - Remove GetKohaAuthorisedValues This patch replaces the call to C4::Koha::GetKohaAuthorisedValues with Koha::AuthorisedValues->search_by_koha_field Test plan: AV descriptions should be displayed on the following pages: - XSLT view - location and ccode - Bibliographic detail, moredetail and OPAC pages - location, ccode, copynumber - returns - location - opac-basket - ccode, location - The 3 reports: catalogue_stats.pl, issues_stats.pl and reserves_stats.pl - location, ccode
Created attachment 55522 [details] [review] Bug 17253: Koha::AuthorisedValues - Remove GetKohaAuthorisedValues This patch replaces the call to C4::Koha::GetKohaAuthorisedValues with Koha::AuthorisedValues->search_by_koha_field Test plan: AV descriptions should be displayed on the following pages: - XSLT view - location and ccode - Bibliographic detail, moredetail and OPAC pages - location, ccode, copynumber - returns - location - opac-basket - ccode, location - The 3 reports: catalogue_stats.pl, issues_stats.pl and reserves_stats.pl - location, ccode
fatal: sha1 information is lacking or useless (C4/Koha.pm)
Created attachment 56306 [details] [review] Bug 17253: Koha::AuthorisedValues - Remove GetKohaAuthorisedValues This patch replaces the call to C4::Koha::GetKohaAuthorisedValues with Koha::AuthorisedValues->search_by_koha_field Test plan: AV descriptions should be displayed on the following pages: - XSLT view - location and ccode - Bibliographic detail, moredetail and OPAC pages - location, ccode, copynumber - returns - location - opac-basket - ccode, location - The 3 reports: catalogue_stats.pl, issues_stats.pl and reserves_stats.pl - location, ccode
I am not seeing location and ccode in Bibliographic detail, more detail, OPAC pages and OPAC basket. Copynumber is displaying in Bibliographic detail and more detail. Returns page: there is a column for location but no value is displayed despite one being set.
(In reply to Claire Gravely from comment #6) > I am not seeing location and ccode in Bibliographic detail, more detail, > OPAC pages and OPAC basket. > > Copynumber is displaying in Bibliographic detail and more detail. > > Returns page: there is a column for location but no value is displayed > despite one being set. Also, from the 3 reports: catalogue_stats.pl - both location and ccode missing AVs from drop down list issues_stats.pl and reserves_stats.pl - ccode missing AVs from list
Created attachment 56336 [details] [review] Bug 17253: Fetch all the columns instead of only authorised_value
(In reply to Jonathan Druart from comment #5) > Created attachment 56306 [details] [review] [review] > Bug 17253: Koha::AuthorisedValues - Remove GetKohaAuthorisedValues > > This patch replaces the call to C4::Koha::GetKohaAuthorisedValues with > Koha::AuthorisedValues->search_by_koha_field > > Test plan: > AV descriptions should be displayed on the following pages: > - XSLT view - location and ccode > - Bibliographic detail, moredetail and OPAC pages - location, ccode, > copynumber [BIB Details page OK with XSLT and without XSLT] [BIB Moredetails page missing location with XSLT and without XSLT - also not displayed on master] [OPAC pages ok with XSLT and without XSLT] > - returns - location [ALL OK] > - opac-basket - ccode, location [ccode not displayed - also not displayed on master] > - The 3 reports: catalogue_stats.pl, issues_stats.pl and > reserves_stats.pl - location, ccode [ALL OK]
Created attachment 56370 [details] [review] Bug 17253: Koha::AuthorisedValues - Remove GetKohaAuthorisedValues This patch replaces the call to C4::Koha::GetKohaAuthorisedValues with Koha::AuthorisedValues->search_by_koha_field Test plan: AV descriptions should be displayed on the following pages: - XSLT view - location and ccode - Bibliographic detail, moredetail and OPAC pages - location, ccode, copynumber - returns - location - opac-basket - ccode, location - The 3 reports: catalogue_stats.pl, issues_stats.pl and reserves_stats.pl - location, ccode Signed-off-by: Claire Gravely <claire_gravely@hotmail.com>
Created attachment 56371 [details] [review] Bug 17253: Fetch all the columns instead of only authorised_value Signed-off-by: Claire Gravely <claire_gravely@hotmail.com>
Created attachment 56404 [details] [review] [PASSED QA] Bug 17253: Koha::AuthorisedValues - Remove GetKohaAuthorisedValues This patch replaces the call to C4::Koha::GetKohaAuthorisedValues with Koha::AuthorisedValues->search_by_koha_field Test plan: AV descriptions should be displayed on the following pages: - XSLT view - location and ccode - Bibliographic detail, moredetail and OPAC pages - location, ccode, copynumber - returns - location - opac-basket - ccode, location - The 3 reports: catalogue_stats.pl, issues_stats.pl and reserves_stats.pl - location, ccode Signed-off-by: Claire Gravely <claire_gravely@hotmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 56405 [details] [review] [PASSED QA] Bug 17253: Fetch all the columns instead of only authorised_value Signed-off-by: Claire Gravely <claire_gravely@hotmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
End of tree.. passed :)
Pushed to master for 16.11, thanks Jonathan!