Add helper plugins for these fields
Created attachment 55454 [details] [review] Bug 17288 - Advanced Editor - Rancor - Helpers for 006 and 007 fields To test: Open advanced cataloging editor Experiment with 006 and 007 fields and ensure helpers function for all material types
Created attachment 55548 [details] [review] Bug 17288: (follow-up) Fix marc21_field_007.xml Bad formatted data in 007 field. Fixed To test follow the previous commit.
Still one error: When you insert an 006 field, position 5 is copied to another selection. For example, when you inster the new field 006 and you change BKS to MX the postion 005 "g" (Target audience--General) is copied to MX, and that position in MX is undefined.
Created attachment 55842 [details] [review] Bug 17288 (QA Followup) Don't default char 5 (is undefined in some forms)
Thanks Hector! I just changed the default line not to populate field 5 - anything you enter there in a form where it is defined will carry over, but I feel like that is safer for when you accidentally click the wrong type.
Comment on attachment 55842 [details] [review] Bug 17288 (QA Followup) > var now = new Date(); This line not needed in both fields.
Created attachment 55854 [details] [review] Bug 17288: (follow-up) Remove unneccessary Date() function Remove line: var now = new Date(); from both subfields
Advanced editor still has some errors, for example, if you choose another category of material different to BKS and save record or switch between basic and advanced editor, the type of material get back to BKS in fixed fields (i.e., 006, 008). On the contrary if you open a existing record, for example, continue resources the 008 will be BKS and not CR (Continue resources) But I think this is out of the scope of this bug.
Created attachment 55855 [details] [review] Bug 17288: (follow-up) Remove unneccessary Date() function Remove line: var now = new Date(); from both subfields Also fix 18 positions (00-17) for default data in 006 field
What is the test plan for this?
(In reply to Owen Leonard from comment #10) > What is the test plan for this? Hi Owen, please follow the first commit by Nick
Created attachment 63059 [details] [review] [SIGNED-OFF] Bug 17288 - Advanced Editor - Rancor - Helpers for 006 and 007 fields To test: Open advanced cataloging editor Experiment with 006 and 007 fields and ensure helpers function for all material types Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 63060 [details] [review] [SIGNED-OFF] Bug 17288: (follow-up) Fix marc21_field_007.xml Bad formatted data in 007 field. Fixed To test follow the previous commit. Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 63061 [details] [review] [SIGNED-OFF] Bug 17288 (QA Followup) Don't default char 5 (is undefined in some forms) Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 63062 [details] [review] [SIGNED-OFF] Bug 17288: (follow-up) Remove unneccessary Date() function Remove line: var now = new Date(); from both subfields Also fix 18 positions (00-17) for default data in 006 field Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 66465 [details] [review] Bug 17288 - Advanced Editor - Rancor - Helpers for 006 and 007 fields To test: Open advanced cataloging editor Experiment with 006 and 007 fields and ensure helpers function for all material types Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 66466 [details] [review] Bug 17288: (follow-up) Fix marc21_field_007.xml Bad formatted data in 007 field. Fixed To test follow the previous commit. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 66467 [details] [review] Bug 17288 (QA Followup) Don't default char 5 (is undefined in some forms) Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 66468 [details] [review] Bug 17288: (follow-up) Remove unneccessary Date() function Remove line: var now = new Date(); from both subfields Also fix 18 positions (00-17) for default data in 006 field Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
QA Comment: Not a trivial patch. And small is also arguable ;) Looks good to me. Did not test in Rancor.
Pushed to master for 17.11, thanks to everybody involved!
Enhancement not pushed to 17.05.x