If the preference AnonSuggestions is changed to Allow and AnonymousPatron is left in default (0), when an unauthenticated patron send a new purchase suggestion using the form (opac-suggestions.pl?op=add) appear: Software error: DBIx::Class::ResultSet::create(): Column 'suggestedby' cannot be null at /usr/share/koha/lib/C4/Suggestions.pm line 457
It's a configuration issue, you should get a warning in the about page, but something is buggy. Patch is coming.
Created attachment 55554 [details] [review] Bug 17296: Display warning if AnonymousPatron is not correctly set Bug 14655 added a warning to the about page ("System information" tab) if the AnonymousPatron feature is not correctly configured. But actually there is one case when it's not displayed. Test plan: Set AnonymousPatron to a non existing patron Set at least 1 borrowers.privacy == 2 go on the about page. Without this patch you do not get the warning With this patch you will see "Some patrons have requested a privacy on returning item but the AnonymousPatron pref is not set correctly. Set it to a valid borrower number if you want that this feature works correctly."
Created attachment 55555 [details] [review] Bug 17296: Display warning if AnonymousPatron is not correctly set Bug 14655 added a warning to the about page ("System information" tab) if the AnonymousPatron feature is not correctly configured. But actually there is one case when it's not displayed. Test plan: Set AnonymousPatron to a non existing patron Set at least 1 borrowers.privacy == 2 go on the about page. Without this patch you do not get the warning With this patch you will see "Some patrons have requested a privacy on returning item but the AnonymousPatron pref is not set correctly. Set it to a valid borrower number if you want that this feature works correctly." Signed-off-by: Marc <veron@veron.ch>
Created attachment 55653 [details] [review] [PASSED QA] Bug 17296: Display warning if AnonymousPatron is not correctly set Bug 14655 added a warning to the about page ("System information" tab) if the AnonymousPatron feature is not correctly configured. But actually there is one case when it's not displayed. Test plan: Set AnonymousPatron to a non existing patron Set at least 1 borrowers.privacy == 2 go on the about page. Without this patch you do not get the warning With this patch you will see "Some patrons have requested a privacy on returning item but the AnonymousPatron pref is not set correctly. Set it to a valid borrower number if you want that this feature works correctly." Signed-off-by: Marc <veron@veron.ch> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Pushed to master for 16.11, thanks Jonathan!
Pushed in 16.05. Will be in 16.05.05.
Pushed to 3.22.x, will be in 3.22.12