File opac-ics.tt is broken in translations. First line says: [% First line will be summary, second line will be description. Avoid indenting. -%] However, in pootle everything is on one line, and ics won't work on translated pages. %s %s %s is overdue Your copy of %s (barcode %s) is overdue %s %s is due Your copy of %s (barcode %s) is due back at the library today %s See: http://lists.koha-community.org/pipermail/koha-translate/2016-September/002599.html Workaround: Insert newline character directly into the translation. http://lists.koha-community.org/pipermail/koha-translate/2016-September/002600.html Related to Bug 5456 - Create a link to opac-ics.pl
Created attachment 55718 [details] [review] Bug 17322 - Translation breaks opac-ics.tt This patch adds newlines to opac-ics.tt that are preserved by the translating process. To test: - Apply patch - Create a translation (perl translate xy-XY) - With a text editor or poedit, translate misc/translator/po/xy-XY-opac-bootstrap.po (it is enough to translate "%s %s %s %s is overdue %sYour copy of........") - Install language xx-XY and select it for OPAC (perl translate install xy-XY) - Make sure you have at least a couple of loans, including one overdue - Go to /cgi-bin/koha/opac-user.pl and click on the link labeled "Download as iCal/.ics file" - Inspect the file in a text editor and/or view the result in a calendar appplication. Make sure the data makes sense. Compare it to the english version.
Created attachment 55733 [details] [review] Bug 17322 - Translation breaks opac-ics.tt This patch adds newlines to opac-ics.tt that are preserved by the translating process. To test: - Apply patch - Create a translation (perl translate xy-XY) - With a text editor or poedit, translate misc/translator/po/xy-XY-opac-bootstrap.po (it is enough to translate "%s %s %s %s is overdue %sYour copy of........") - Install language xx-XY and select it for OPAC (perl translate install xy-XY) - Make sure you have at least a couple of loans, including one overdue - Go to /cgi-bin/koha/opac-user.pl and click on the link labeled "Download as iCal/.ics file" - Inspect the file in a text editor and/or view the result in a calendar appplication. Make sure the data makes sense. Compare it to the english version. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Works as described
Created attachment 55798 [details] [review] [PASSED QA] Bug 17322 - Translation breaks opac-ics.tt This patch adds newlines to opac-ics.tt that are preserved by the translating process. To test: - Apply patch - Create a translation (perl translate xy-XY) - With a text editor or poedit, translate misc/translator/po/xy-XY-opac-bootstrap.po (it is enough to translate "%s %s %s %s is overdue %sYour copy of........") - Install language xx-XY and select it for OPAC (perl translate install xy-XY) - Make sure you have at least a couple of loans, including one overdue - Go to /cgi-bin/koha/opac-user.pl and click on the link labeled "Download as iCal/.ics file" - Inspect the file in a text editor and/or view the result in a calendar appplication. Make sure the data makes sense. Compare it to the english version. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Pushed to master for 16.11, thanks Marc!
Pushed in 16.05. Will be in 16.05.05.