I noticed some odd things in my installation - turned out, half the preferences where missing because of a typo in the sysprefs.sql file. Attaching a patch in a second.
Created attachment 55796 [details] [review] Bug 17345: Fix typo in sysprefs.sql This fixes a tiny typo in sysprefs.sql that kept all systempreferences from being installed. To test: - Create a new koha database, run the web installer - Verify that all systempreferences have been loaded select count(*) from systempreferences should be no less than 553 or - Truncate your systempreferences table - Verify that the repaired sysprefs.sql file loads without error
Created attachment 55817 [details] [review] Bug 17345: Fix typo in sysprefs.sql This fixes a tiny typo in sysprefs.sql that kept all systempreferences from being installed. To test: - Create a new koha database, run the web installer - Verify that all systempreferences have been loaded select count(*) from systempreferences should be no less than 553 or - Truncate your systempreferences table - Verify that the repaired sysprefs.sql file loads without error Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Tested by truncating systempreferences table
Hi Josef - thx for testing! I noticed later I was missing the Version pref after doing the truncation - maybe something to check!
Erk, sorry about that.
Created attachment 55863 [details] [review] Bug 17345: Fix typo in sysprefs.sql This fixes a tiny typo in sysprefs.sql that kept all systempreferences from being installed. To test: - Create a new koha database, run the web installer - Verify that all systempreferences have been loaded select count(*) from systempreferences should be no less than 553 or - Truncate your systempreferences table - Verify that the repaired sysprefs.sql file loads without error Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed to Master - Should be in the November Release 16.11 - Thanks!