Enable the option to disable the check-in column under Columns settings. This option is under the index tab : circulation and patrons. This option should be enabled, because the check-in is not necessary at this places, so if a library want to hide it, they should get the possibility.
Tobias, This can be easily achieve by removing the 2 flags cannot_be_toggled and cannot_be_modified in the admin/columns_settings.yml Are you able to provide such a patch?
Created attachment 61003 [details] [review] Bug 17346: Make checkin column hidable
Hope you don't mind. I took the liberty to write the patch. To test: 1) Go to columns_settings.pl --> Circulation --> issues-table and note that you cannot change the settings for checkin. 2) Go to columns_settings.pl --> Patrons --> issues-table and note that you cannot change the settings for checkin. 3) Apply the patch. 4) Go to both tables again and note that you can now change the settings.
Created attachment 61012 [details] [review] Bug 17346: Make checkin column hidable To test: 1) Go to columns_settings.pl --> Circulation --> issues-table and note that you cannot change the settings for checkin. 2) Go to columns_settings.pl --> Patrons --> issues-table and note that you cannot change the settings for checkin. 3) Apply the patch. 4) Go to both tables again and note that you can now change the settings. Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch>
I finally remember why the action columns were not modifiable. There is something wrong happening if you select checkin hidden by default and can be toggled. When you show it, the tr element "Today's checkouts" does not display correctly. Not sure how to fix that cleanly...
(In reply to Jonathan Druart from comment #5) > I finally remember why the action columns were not modifiable. > There is something wrong happening if you select checkin hidden by default > and can be toggled. > When you show it, the tr element "Today's checkouts" does not display > correctly. > > Not sure how to fix that cleanly... I will look into it, but if I can't find a resolution, at least we can still lock the option to toggle it. That would be a reasonable compromise.
Please QA again. It appears this is a pre-existing condition, and will happen with any column that is hidden by default and then toggled on. I will open a new ticket for this condition. Christopher
Created attachment 61372 [details] [review] Bug 17346: Make checkin column hidable To test: 1) Go to columns_settings.pl --> Circulation --> issues-table and note that you cannot change the settings for checkin. 2) Go to columns_settings.pl --> Patrons --> issues-table and note that you cannot change the settings for checkin. 3) Apply the patch. 4) Go to both tables again and note that you can now change the settings. Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed to master for 17.05, thanks Christopher!
Holding back on this because of comment#5 for the stable release. Please link the new bug with this one once opened.
(In reply to Katrin Fischer from comment #10) > Holding back on this because of comment#5 for the stable release. > Please link the new bug with this one once opened. Comment 5 was wrong and the behavior I described is not added by this patch. New bug is linked already, it's bug 18257.
*** Bug 15441 has been marked as a duplicate of this bug. ***
Tiny change - I have decided to push this to 16.11.x. This patch has been pushed to 16.11.x and will be in 16.11.07.
Pushed to 16.05.x, for 16.05.12 release