The patron search type is hard coded to 'contain' in circ/circulation.pl. This causes problems because a mis-scanned cardnumber can bring up the wrong patron. The example that our partner gave us involved scanning '1733', which doesn't match any borrowers when we do a 'start_with' search, but matches the cardnumber 'p291733'. If we follow the usage in members/member.pl, we can set searchtype in HTTP params, which is amenable to fixes in intranetuserjs
Created attachment 55823 [details] [review] Bug 17352 - Patron search type is hard coded to 'contain' in circ/circulation.pl The patron search type is hard coded to 'contain' in circ/circulation.pl. This causes problems because a mis-scanned cardnumber can bring up the wrong patron. The example that our partner gave us involved scanning '1733', which doesn't match any borrowers when we do a 'start_with' search, but matches the cardnumber 'p291733'. If we follow the usage in members/member.pl, we can set searchtype in HTTP params, which is amenable to fixes in intranetuserjs Test Plan: 1) Apply this patch 2) Use the checkout search, not changes should be noted Extra credit: 1) Add javascript to intranetuserjs to add a hidden input named 'searchtype' with the value 'start_with' 2) Checkout searches should now give only results where a searched field starts with the given string(s)
Created attachment 55832 [details] [review] Bug 17352 - Patron search type is hard coded to 'contain' in circ/circulation.pl The patron search type is hard coded to 'contain' in circ/circulation.pl. This causes problems because a mis-scanned cardnumber can bring up the wrong patron. The example that our partner gave us involved scanning '1733', which doesn't match any borrowers when we do a 'start_with' search, but matches the cardnumber 'p291733'. If we follow the usage in members/member.pl, we can set searchtype in HTTP params, which is amenable to fixes in intranetuserjs Test Plan: 1) Apply this patch 2) Use the checkout search, not changes should be noted Extra credit: 1) Add javascript to intranetuserjs to add a hidden input named 'searchtype' with the value 'start_with' 2) Checkout searches should now give only results where a searched field starts with the given string(s) Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Tested with extra ;)
Created attachment 55843 [details] [review] Bug 17352 - Patron search type is hard coded to 'contain' in circ/circulation.pl The patron search type is hard coded to 'contain' in circ/circulation.pl. This causes problems because a mis-scanned cardnumber can bring up the wrong patron. The example that our partner gave us involved scanning '1733', which doesn't match any borrowers when we do a 'start_with' search, but matches the cardnumber 'p291733'. If we follow the usage in members/member.pl, we can set searchtype in HTTP params, which is amenable to fixes in intranetuserjs Test Plan: 1) Apply this patch 2) Use the checkout search, not changes should be noted Extra credit: 1) Add javascript to intranetuserjs to add a hidden input named 'searchtype' with the value 'start_with' 2) Checkout searches should now give only results where a searched field starts with the given string(s) Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed to master, thanks for the quick turnaround on this Josef, Jonathan!
Pushed to master for 16.11
Pushed in 16.05. Will be in 16.05.05.
Pushed to 3.22.x, will be in 3.22.12