In OPAC details page, when record as too many items (depending on syspref OpacMaxItemsToDisplay), they are not displayed in holdings tab. You can click on link "Click here to view them all" to show them : page reloads with a new arg viewallitems=1. Also you can choose which tab is shown by default using syspref opacSerialDefaultTab. The bug is that when default tab is not holdings, clicking on link to show all items will show another tab. So one must reclick on holings tab to see all items.
Created attachment 55886 [details] [review] Bug 17367 - Showing all items must keep show holdings tab in OPAC details In OPAC details page, when record as too many items (depending on syspref OpacMaxItemsToDisplay), they are not displayed in holdings tab. You can click on link "Click here to view them all" to show them : page reloads with a new arg viewallitems=1. Also you can choose which tab is shown by default using syspref opacSerialDefaultTab. The bug is that when default tab is not holdings, clicking on link to show all items will show another tab. So one must reclick on holings tab to see all items. This patch corrects by forcing holdings tab when arg viewallitems is defined. Test plan : - Create a serial record with more items than syspref OpacMaxItemsToDisplay (or decrease this syspref) - Select "Subscriptions tab" for syspref opacSerialDefaultTab - Go to opac details on this record : /cgi-bin/koha/opac-detail.pl?biblionumber=xxx => You see Subscriptions tab selected - Click on Holdings tab => You see no items but a link "Click here to view them all" - Click on this link => Without patch you see Subscriptions tab selected => Wih patch you see Holdings tab selected and the items
i test the patch with de biblibre sandbox N°7 but the system preference opacSerialDefaultTab does not work and the enabling this system preference hide the link "Click here to view them all" in the tab "Holdings"
Patch tested with a sandbox, by Juliette <juliette.levast@iepg.fr>
Created attachment 56193 [details] [review] Bug 17367 - Showing all items must keep show holdings tab in OPAC details In OPAC details page, when record as too many items (depending on syspref OpacMaxItemsToDisplay), they are not displayed in holdings tab. You can click on link "Click here to view them all" to show them : page reloads with a new arg viewallitems=1. Also you can choose which tab is shown by default using syspref opacSerialDefaultTab. The bug is that when default tab is not holdings, clicking on link to show all items will show another tab. So one must reclick on holings tab to see all items. This patch corrects by forcing holdings tab when arg viewallitems is defined. Test plan : - Create a serial record with more items than syspref OpacMaxItemsToDisplay (or decrease this syspref) - Select "Subscriptions tab" for syspref opacSerialDefaultTab - Go to opac details on this record : /cgi-bin/koha/opac-detail.pl?biblionumber=xxx => You see Subscriptions tab selected - Click on Holdings tab => You see no items but a link "Click here to view them all" - Click on this link => Without patch you see Subscriptions tab selected => Wih patch you see Holdings tab selected and the items Signed-off-by: Juliette <juliette.levast@iepg.fr>
Created attachment 56541 [details] [review] Bug 17367 - Showing all items must keep show holdings tab in OPAC details In OPAC details page, when record as too many items (depending on syspref OpacMaxItemsToDisplay), they are not displayed in holdings tab. You can click on link "Click here to view them all" to show them : page reloads with a new arg viewallitems=1. Also you can choose which tab is shown by default using syspref opacSerialDefaultTab. The bug is that when default tab is not holdings, clicking on link to show all items will show another tab. So one must reclick on holings tab to see all items. This patch corrects by forcing holdings tab when arg viewallitems is defined. Test plan : - Create a serial record with more items than syspref OpacMaxItemsToDisplay (or decrease this syspref) - Select "Subscriptions tab" for syspref opacSerialDefaultTab - Go to opac details on this record : /cgi-bin/koha/opac-detail.pl?biblionumber=xxx => You see Subscriptions tab selected - Click on Holdings tab => You see no items but a link "Click here to view them all" - Click on this link => Without patch you see Subscriptions tab selected => Wih patch you see Holdings tab selected and the items Signed-off-by: Juliette <juliette.levast@iepg.fr> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
I don't really like the viewalitems as a URL parameter, page refreshes don't revert to the original view, but that is more a comment saying this page would be a good candidate for a js render/Rest API call, but that's a different bug. Nice work Frido!
Pushed to Master - Should be in the November 16.11 Release. Thanks!
Pushed in 16.05. Will be in 16.05.05.
Pushed in 3.22.x, will be in 3.22.12
(In reply to Nick Clemens from comment #6) > I don't really like the viewalitems as a URL parameter, page refreshes don't > revert to the original view, but that is more a comment saying this page > would be a good candidate for a js render/Rest API call, but that's a > different bug. Indeed, REST API would be pretty cool. Maybe with a paginated JS DataTable.