ReturnpathDefault and possibly others are missing from sysprefs.sql.
I checked the tests, but couldn't find one checking the sysprefs.sql for completeness. Is there any other way we could find missing ones automatically?
Created attachment 56570 [details] [review] Bug 17391: Add missing prefs to sysprefs.sql Adds - ReturnpathDefault - ReplytoDefault to the sysprefs.sql file. To test: - Run the web installer in any language - Check all preferences are installed without error - Check prefs listed above now exsit in your systempreferences table
I am not sure, should we do a git an 'INSERT IGNORE...' atomic update here?
(In reply to Katrin Fischer from comment #3) > I am not sure, should we do a git an 'INSERT IGNORE...' atomic update here? Yes we definitely need it.
(In reply to Katrin Fischer from comment #1) > I checked the tests, but couldn't find one checking the sysprefs.sql for > completeness. Is there any other way we could find missing ones > automatically? t/db_dependent/check_sysprefs.t is comparing sysprefs.sql with the prefs in DB. So if you install a fresh instance with sysprefs.sql, the test will not see any differences.
(In reply to Jonathan Druart from comment #4) > (In reply to Katrin Fischer from comment #3) > > I am not sure, should we do a git an 'INSERT IGNORE...' atomic update here? > > Yes we definitely need it. Not really actually, but for consistency It is better
Created attachment 57588 [details] [review] Bug 17391: Add missing prefs to sysprefs.sql Adds - ReturnpathDefault - ReplytoDefault to the sysprefs.sql file. To test: - Run the web installer in any language - Check all preferences are installed without error - Check prefs listed above now exsit in your systempreferences table Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Created attachment 57589 [details] [review] Bug 17391: Add atomic update file Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Created attachment 57590 [details] [review] Bug 17391: Fix number of values in sysprefs.sql Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Created attachment 57699 [details] [review] Bug 17391: Add missing prefs to sysprefs.sql Adds - ReturnpathDefault - ReplytoDefault to the sysprefs.sql file. To test: - Run the web installer in any language - Check all preferences are installed without error - Check prefs listed above now exsit in your systempreferences table Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Created attachment 57700 [details] [review] Bug 17391: Add atomic update file Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Created attachment 57701 [details] [review] Bug 17391: Fix number of values in sysprefs.sql Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Created attachment 57702 [details] [review] Bug 17391 (QA Followup) use INSERT INGORE in atomicupdate Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Pushed to master for 16.11, thanks Katrin, Jonathan, Nick!
Pushed to 3.22.x, will be in 3.22.13