In checkouts table, the is an export form (when some exports syspref are enabled). When selecting some checkouts and selecting "ISO2709 with items" in export format combo-box, clicking on "Export" will select "ISO2709 without items" in the export format combo-box. This is quite strange. Its because the form as 2 inputs with same name and id "output_format" : an hidden input (the wanted arg for tools/export.pl) and a select (the export format combo-box). So an action meant on the hidden input impacts the select.
Created attachment 56018 [details] [review] Bug 17394 - exporting checkouts with items selects without items in combo-box In checkouts table, the is an export form (when some exports syspref are enabled). When selecting some checkouts and selecting "ISO2709 with items" in export format combo-box, clicking on "Export" will select "ISO2709 without items" in the export format combo-box. This is quite strange. Its because the form as 2 inputs with same name and id "output_format" : an hidden input (the wanted arg for tools/export.pl) and a select (the export format combo-box). So an action meant on the hidden input impacts the select. This patch corrects by changing id and name of the export format combo-box : issues-table-output-format TEST plan : - Enable checkouts exports by setting syspref ExportWithCsvProfile with a profile - Go to circ page of a patron with checkouts : /cgi-bin/koha/circ/circulation.pl?borrowernumber=xxx - Show checkouts table - Select some checkboxes in "Export" column - Select "ISO2709 with items" in export format combo-box - Click on "Export" => Without patch, the export format combo-box changes to "ISO2709 without items" => Without patch, the export format combo-box does not changes - Check the export file contains the items - Check exports "ISO2709 without items" and "CSV" are OK
Created attachment 56020 [details] [review] Bug 17394 - exporting checkouts with items selects without items in combo-box In checkouts table, the is an export form (when some exports syspref are enabled). When selecting some checkouts and selecting "ISO2709 with items" in export format combo-box, clicking on "Export" will select "ISO2709 without items" in the export format combo-box. This is quite strange. Its because the form as 2 inputs with same name and id "output_format" : an hidden input (the wanted arg for tools/export.pl) and a select (the export format combo-box). So an action meant on the hidden input impacts the select. This patch corrects by changing id and name of the export format combo-box : issues-table-output-format TEST plan : - Enable checkouts exports by setting syspref ExportWithCsvProfile with a profile - Go to circ page of a patron with checkouts : /cgi-bin/koha/circ/circulation.pl?borrowernumber=xxx - Show checkouts table - Select some checkboxes in "Export" column - Select "ISO2709 with items" in export format combo-box - Click on "Export" => Without patch, the export format combo-box changes to "ISO2709 without items" => With patch, the export format combo-box does not changes - Check the export file contains the items - Check exports "ISO2709 without items" and "CSV" are OK
Created attachment 56092 [details] [review] Bug 17394 - exporting checkouts with items selects without items in combo-box In checkouts table, the is an export form (when some exports syspref are enabled). When selecting some checkouts and selecting "ISO2709 with items" in export format combo-box, clicking on "Export" will select "ISO2709 without items" in the export format combo-box. This is quite strange. Its because the form as 2 inputs with same name and id "output_format" : an hidden input (the wanted arg for tools/export.pl) and a select (the export format combo-box). So an action meant on the hidden input impacts the select. This patch corrects by changing id and name of the export format combo-box : issues-table-output-format TEST plan : - Enable checkouts exports by setting syspref ExportWithCsvProfile with a profile - Go to circ page of a patron with checkouts : /cgi-bin/koha/circ/circulation.pl?borrowernumber=xxx - Show checkouts table - Select some checkboxes in "Export" column - Select "ISO2709 with items" in export format combo-box - Click on "Export" => Without patch, the export format combo-box changes to "ISO2709 without items" => With patch, the export format combo-box does not changes - Check the export file contains the items - Check exports "ISO2709 without items" and "CSV" are OK Signed-off-by: Jesse Maseto <jesse@bywatersolutions.com>
Created attachment 57228 [details] [review] [PASSED QA] Bug 17394 - exporting checkouts with items selects without items in combo-box In checkouts table, the is an export form (when some exports syspref are enabled). When selecting some checkouts and selecting "ISO2709 with items" in export format combo-box, clicking on "Export" will select "ISO2709 without items" in the export format combo-box. This is quite strange. Its because the form as 2 inputs with same name and id "output_format" : an hidden input (the wanted arg for tools/export.pl) and a select (the export format combo-box). So an action meant on the hidden input impacts the select. This patch corrects by changing id and name of the export format combo-box : issues-table-output-format TEST plan : - Enable checkouts exports by setting syspref ExportWithCsvProfile with a profile - Go to circ page of a patron with checkouts : /cgi-bin/koha/circ/circulation.pl?borrowernumber=xxx - Show checkouts table - Select some checkboxes in "Export" column - Select "ISO2709 with items" in export format combo-box - Click on "Export" => Without patch, the export format combo-box changes to "ISO2709 without items" => With patch, the export format combo-box does not changes - Check the export file contains the items - Check exports "ISO2709 without items" and "CSV" are OK Signed-off-by: Jesse Maseto <jesse@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Pushed to master for 16.11, thanks Frido!
Pushed to 3.22.x, will be in 3.22.13
Pushed to 16.05.x, for 16.05.06 release