Title and breadcrumb of patron deletion page (deletemember.pl) say: "Can't Delete Patron". This should be changed to "Delete patron". To verify: - Go to a patron's detail page - Toolbar : More : Delete - You get a question: "Are you sure...", but title and breadcrumb say: "Can't Delete Patron" rsp "Cant delete patron"
Created attachment 56056 [details] [review] Bug 17404: Patron deletion page: Fix title and breadcrumb Title and breadcrumb of patron deletion page (deletemember.pl) say: "Can't Delete Patron". This should be changed to "Delete patron". To verify: - Go to a patron's detail page - Toolbar : More : Delete Result: You get a question: "Are you sure...", but title and breadcrumb say: "Can't Delete Patron" rsp "Cant delete patron" To test: - Apply patch - Repeat steps above. - Verify that title and breadcrumb display properly, including patron's name
Created attachment 56095 [details] [review] Bug 17403: Patron deletion page: Fix title and breadcrumb Title and breadcrumb of patron deletion page (deletemember.pl) say: "Can't Delete Patron". This should be changed to "Delete patron". To verify: - Go to a patron's detail page - Toolbar : More : Delete Result: You get a question: "Are you sure...", but title and breadcrumb say: "Can't Delete Patron" rsp "Cant delete patron" To test: - Apply patch - Repeat steps above. - Verify that title and breadcrumb display properly, including patron's name Signed-off-by: Claire Gravely <claire_gravely@hotmail.com>
Created attachment 56691 [details] [review] Bug 17404: Patron deletion page: Fix title and breadcrumb Title and breadcrumb of patron deletion page (deletemember.pl) say: "Can't Delete Patron". This should be changed to "Delete patron". To verify: - Go to a patron's detail page - Toolbar : More : Delete Result: You get a question: "Are you sure...", but title and breadcrumb say: "Can't Delete Patron" rsp "Cant delete patron" To test: - Apply patch - Repeat steps above. - Verify that title and breadcrumb display properly, including patron's name Signed-off-by: Claire Gravely <claire_gravely@hotmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Personally, I would not add the names in title and breadcrumbs. No blocker.
Pushed to master for 16.11, thanks Marc!
Pushed in 16.05. Will be in 16.05.05.
Pushed in 3.22.x, will be in 3.22.12