In acqui/basket.pl line 236, the statement exit 1 is most likely to lead to an Internal Server Error. It should be exit 0.
Created attachment 56076 [details] [review] Bug 17411 - Change exit 1 to exit 0 in acqui/basket.pl to prevent Internal Server Error Note: Same situation as in Bug 17403 To test: - Verifiy that code change makes sense. Note: Same situation as in Bug 17403
Created attachment 56121 [details] [review] Bug 17411 - Change exit 1 to exit 0 in acqui/basket.pl to prevent Internal Server Error Note: Same situation as in Bug 17403 To test: - Verifiy that code change makes sense. Note: Same situation as in Bug 17403 Signed-off-by: David Cook <dcook@prosentient.com.au> Without a step-by-step test plan, I wasn't sure how to test this. However, the code change is simple enough, and makes sense.
David, you forgot to change bug status to signed-off
(In reply to Héctor Eduardo Castro Avalos from comment #3) > David, you forgot to change bug status to signed-off Thanks, Héctor :).
Created attachment 56627 [details] [review] Bug 17411 - Change exit 1 to exit 0 in acqui/basket.pl to prevent Internal Server Error Note: Same situation as in Bug 17403 To test: - Verifiy that code change makes sense. Note: Same situation as in Bug 17403 Signed-off-by: David Cook <dcook@prosentient.com.au> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Amended patch: Remove unecessary comment
Created attachment 56628 [details] [review] Bug 17411: Remove 3 other occurrences of exit 1
Pushed to master for 16.11, thanks Marc, Jonathan!
Pushed in 16.05. Will be in 16.05.05.
Pushed in 3.22.x, will be in 3.22.12