Under certain circumstances the Primary and Secondary Phone will appear twice on the Patron record. When looking at the moremember.tt file line 236 has an IF block that displays the Primary and Secondary Phone value if the category_code ="P". I can't see any documentation as to why this is and what the "P" might mean. If a site adds their own category code and it equals "P", this duplication will occur.
Created attachment 56633 [details] [review] Bug 17434: Moremember displaying primary and secondary phone number twice Test plan: 1) Create patron category with category code "P" and create a patron with this category 2) Fill in either the primary or other phone number 3) Go to patron details page (moremember.pl) => without patch you see primary/other phone duplicated => with patch you should see the number only once as expected
Created attachment 56710 [details] [review] Bug 17434: Moremember displaying primary and secondary phone number twice Test plan: 1) Create patron category with category code "P" and create a patron with this category 2) Fill in either the primary or other phone number 3) Go to patron details page (moremember.pl) => without patch you see primary/other phone duplicated => with patch you should see the number only once as expected Signed-off-by: Lucio Moraes <lmoraes@catalyst.net.nz>
Created attachment 56711 [details] [review] Bug 17434: Moremember displaying primary and secondary phone number twice Test plan: 1) Create patron category with category code "P" and create a patron with this category 2) Fill in either the primary or other phone number 3) Go to patron details page (moremember.pl) => without patch you see primary/other phone duplicated => with patch you should see the number only once as expected Signed-off-by: Lucio Moraes <lmoraes@catalyst.net.nz>
Created attachment 56832 [details] [review] Bug 17434: Moremember displaying primary and secondary phone number twice Test plan: 1) Create patron category with category code "P" and create a patron with this category 2) Fill in either the primary or other phone number 3) Go to patron details page (moremember.pl) => without patch you see primary/other phone duplicated => with patch you should see the number only once as expected Signed-off-by: Lucio Moraes <lmoraes@catalyst.net.nz> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Pushed to master for 16.11, thanks Josef!
Pushed in 16.05. Will be in 16.05.06.
Pushed to 3.22.x, will be in 3.22.13