In our we need to base patron's new expiry date on the later of expiry and current date. To be more clear: if patron registration expires in the past, use current date, if patron registration expires in the future, use expiry date.
Created attachment 56443 [details] [review] Bug 17443: Make possible to renew patron by later of expiry and current date Test plan 1) Apply the patch 2) Go to system preferences and find the BorrowerRenewalPeriodBase and note there is new option "the later of current and expiry date" 3) Try all three options and confirm they work as expected 3.1) The new options should be tested et least with two patrons - one with expiry date in past and one with expiry date in future
Created attachment 56457 [details] [review] Bug 17443: Make possible to renew patron by later of expiry and current date Test plan 1) Apply the patch 2) Go to system preferences and find the BorrowerRenewalPeriodBase and note there is new option "the later of current and expiry date" 3) Try all three options and confirm they work as expected 3.1) The new options should be tested et least with two patrons - one with expiry date in past and one with expiry date in future Signed-off-by: radiuscz <radek.siman@centrum.cz>
Please provide tests.
Created attachment 56845 [details] [review] Bug 17443: Added tests Test plan: prove t/db_dependent/Koha/Patrons.t
Created attachment 56849 [details] [review] Bug 17443: Make possible to renew patron by later of expiry and current date Test plan 1) Apply the patch 2) Go to system preferences and find the BorrowerRenewalPeriodBase and note there is new option "the later of current and expiry date" 3) Try all three options and confirm they work as expected 3.1) The new options should be tested et least with two patrons - one with expiry date in past and one with expiry date in future Signed-off-by: radiuscz <radek.siman@centrum.cz> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Created attachment 56850 [details] [review] Bug 17443: Added tests Test plan: prove t/db_dependent/Koha/Patrons.t Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Pushed to master for 16.11, thanks Josef!
Pushed in 16.05. Will be in 16.05.06.