Hi, When we just consult receipt summary (parcel.pl), the ID of logged user is displayed in field "Received by" But effective receipt were done by someone else. Id of user who done receipt is logged somewhere? Regards, Marjorie
It indeed always displayed the current user: <strong>Received by:</strong> [% logged_in_user.userid | html %] This is on the receive, not on the invoice page, although both are linked of course. We don't store who started/created an invoice. Also: The orders in a shipment/invoice could have been processed by different people, it makes no sense to display a single user at the top, when it can vary for different entries on the page. So I think best is to remove the misleading information.
Actually, the same is true for the "On" date. It always displays today's date...
Created attachment 103208 [details] [review] Bug 17458: Fix information shown on top of order receive page Before this patch the order receive page (parcel.pl) would show ... Received by: <current user> On: <current date> This is not really helpful. Whenever you viewed an invoice, it would tell you it was _you_ who received that _today_. As we don't store a creator of an invoice and the order lines in an invoice could have been received by different people (which we also don't know about), the "Received by" is removed by this patch. Instead of today's date, we can show the shipment date entered for the invoice. Again: different order lines could have been received on different dates for this shipment. To test: - Create a basket with some orders in acq - Close the basket - Receive shipment and create an invoice - Make sure shipment date is not set to today - Verify the information shown on top of parcel.pl is you and today - Change staff users - Go to your invoice, it's now this user and today - Apply patch - Received by: should be gone and the On: replaced by Shipment date: with the date you selected If you have older invoices in your system, it would work even better with these as you'd see that always today's date is displaying without the patch.
Created attachment 103263 [details] [review] Bug 17458: Fix information shown on top of order receive page Before this patch the order receive page (parcel.pl) would show ... Received by: <current user> On: <current date> This is not really helpful. Whenever you viewed an invoice, it would tell you it was _you_ who received that _today_. As we don't store a creator of an invoice and the order lines in an invoice could have been received by different people (which we also don't know about), the "Received by" is removed by this patch. Instead of today's date, we can show the shipment date entered for the invoice. Again: different order lines could have been received on different dates for this shipment. To test: - Create a basket with some orders in acq - Close the basket - Receive shipment and create an invoice - Make sure shipment date is not set to today - Verify the information shown on top of parcel.pl is you and today - Change staff users - Go to your invoice, it's now this user and today - Apply patch - Received by: should be gone and the On: replaced by Shipment date: with the date you selected If you have older invoices in your system, it would work even better with these as you'd see that always today's date is displaying without the patch. Signed-off-by: Marjorie <marjorie.barry-vila@collecto.ca>
Thx Marjorie!
Katrin, there are occurrences of "datereceived" in the template, however you removed it from the .pl file.
Created attachment 108279 [details] [review] Bug 17458: Remove use of datereceived from order receive page Before this patch the order receive page (parcel.pl) would show ... Received by: <current user> On: <current date> This is not really helpful. Whenever you viewed an invoice, it would tell you it was _you_ who received that _today_. As we don't store a creator of an invoice and the order lines in an invoice could have been received by different people (which we also don't know about), the "Received by" is removed by this patch. Instead of today's date, we can show the shipment date entered for the invoice. Again: different order lines could have been received on different dates for this shipment. So only the shipment date makes sense as it's on invoice level. This also makes changes to the page title, breadcrumby and page heading: When the invoice is closed, they will read: Receipt summary for [vendor] ... When the invoice is not closed, they wil read: Receive orders from [vendor] ... To test: - Create a basket with some orders in acq - Close the basket - Receive shipment and create an invoice - Make sure shipment date is not set to today - Verify the information shown on top of parcel.pl is you and today - Change staff users - Go to your invoice, it's now this user and today - Apply patch - Received by: should be gone and the On: replaced by Shipment date: with the date you selected - Check the page title, breadcrumbs and headings read all the same 'Receive orders...' - Finish receiving and close the invoice - "Go to receipt page" - Verify they now read "Receipt summary.." If you have older invoices in your system, it would work even better with these as you'd see that always today's date is displaying without the patch. Signed-off-by: Marjorie <marjorie.barry-vila@collecto.ca>
I am sorry, this should have been a follow-up - I hadn't realized that Marjorie had already signed off. I removed the other datereceived calls after looking at the template some more. It doesn't make sense to have checks for today's date... it's always there!
Test plan was amended, these are the new bits: This also makes changes to the page title, breadcrumby and page heading: When the invoice is closed, they will read: Receipt summary for [vendor] ... When the invoice is not closed, they wil read: Receive orders from [vendor] ... ... - Check the page title, breadcrumbs and headings read all the same 'Receive orders...' - Finish receiving and close the invoice - "Go to receipt page" - Verify they now read "Receipt summary.."
Created attachment 110302 [details] [review] Bug 17458: Remove use of datereceived from order receive page Before this patch the order receive page (parcel.pl) would show ... Received by: <current user> On: <current date> This is not really helpful. Whenever you viewed an invoice, it would tell you it was _you_ who received that _today_. As we don't store a creator of an invoice and the order lines in an invoice could have been received by different people (which we also don't know about), the "Received by" is removed by this patch. Instead of today's date, we can show the shipment date entered for the invoice. Again: different order lines could have been received on different dates for this shipment. So only the shipment date makes sense as it's on invoice level. This also makes changes to the page title, breadcrumby and page heading: When the invoice is closed, they will read: Receipt summary for [vendor] ... When the invoice is not closed, they wil read: Receive orders from [vendor] ... To test: - Create a basket with some orders in acq - Close the basket - Receive shipment and create an invoice - Make sure shipment date is not set to today - Verify the information shown on top of parcel.pl is you and today - Change staff users - Go to your invoice, it's now this user and today - Apply patch - Received by: should be gone and the On: replaced by Shipment date: with the date you selected - Check the page title, breadcrumbs and headings read all the same 'Receive orders...' - Finish receiving and close the invoice - "Go to receipt page" - Verify they now read "Receipt summary.." If you have older invoices in your system, it would work even better with these as you'd see that always today's date is displaying without the patch. Signed-off-by: Marjorie <marjorie.barry-vila@collecto.ca> Signed-off-by: David Nind <david@davidnind.com>
Created attachment 110744 [details] [review] Bug 17458: Remove use of datereceived from order receive page Before this patch the order receive page (parcel.pl) would show ... Received by: <current user> On: <current date> This is not really helpful. Whenever you viewed an invoice, it would tell you it was _you_ who received that _today_. As we don't store a creator of an invoice and the order lines in an invoice could have been received by different people (which we also don't know about), the "Received by" is removed by this patch. Instead of today's date, we can show the shipment date entered for the invoice. Again: different order lines could have been received on different dates for this shipment. So only the shipment date makes sense as it's on invoice level. This also makes changes to the page title, breadcrumby and page heading: When the invoice is closed, they will read: Receipt summary for [vendor] ... When the invoice is not closed, they wil read: Receive orders from [vendor] ... To test: - Create a basket with some orders in acq - Close the basket - Receive shipment and create an invoice - Make sure shipment date is not set to today - Verify the information shown on top of parcel.pl is you and today - Change staff users - Go to your invoice, it's now this user and today - Apply patch - Received by: should be gone and the On: replaced by Shipment date: with the date you selected - Check the page title, breadcrumbs and headings read all the same 'Receive orders...' - Finish receiving and close the invoice - "Go to receipt page" - Verify they now read "Receipt summary.." If you have older invoices in your system, it would work even better with these as you'd see that always today's date is displaying without the patch. Signed-off-by: Marjorie <marjorie.barry-vila@collecto.ca> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Well sleuthed, it's clearer now. Passing QA
Pushed to master for 20.11, thanks to everybody involved!
doesnt apply clean to 20.05.x, no backport