The 3rd step of patron modification which can be displayed directly using the following link for instance /cgi-bin/koha/members/memberentry.pl?op=modify&borrowernumber=3&step=3 is not checking patron's age, so it allows to set off-limit category.
This issue is filed after confirmation with Jonathan Druart and it has a connection to bug 17492.
Created attachment 57011 [details] [review] Bug 17521: Added missing age limit check Following patron modification partial editor had no age constraint checking: /cgi-bin/koha/members/memberentry.pl?op=modify&borrowernumber=3&step=3 Test plan: 1) Apply the patch 2) Open profile of a patron 3) Click Edit under "Library use": http://prntscr.com/d1ghim 4) Change category to an invalid one (eg. Adult instead of Kid) 5) Error saying "Patron's age is incorrect for their category." should be displayed.
Created attachment 57121 [details] [review] [SIGNED-OFF] Bug 17521: Added missing age limit check Following patron modification partial editor had no age constraint checking: /cgi-bin/koha/members/memberentry.pl?op=modify&borrowernumber=3&step=3 Test plan: 1) Apply the patch 2) Open profile of a patron 3) Click Edit under "Library use": http://prntscr.com/d1ghim 4) Change category to an invalid one (eg. Adult instead of Kid) 5) Error saying "Patron's age is incorrect for their category." should be displayed. Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 57122 [details] [review] Bug 17521: Added missing age limit check Following patron modification partial editor had no age constraint checking: /cgi-bin/koha/members/memberentry.pl?op=modify&borrowernumber=3&step=3 Test plan: 1) Apply the patch 2) Open profile of a patron 3) Click Edit under "Library use": http://prntscr.com/d1ghim 4) Change category to an invalid one (eg. Adult instead of Kid) 5) Error saying "Patron's age is incorrect for their category." should be displayed. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Lucio Moraes <lmoraes@catalyst.net.nz>
Created attachment 57166 [details] [review] Bug 17521: Added missing age limit check Following patron modification partial editor had no age constraint checking: /cgi-bin/koha/members/memberentry.pl?op=modify&borrowernumber=3&step=3 Test plan: 1) Apply the patch 2) Open profile of a patron 3) Click Edit under "Library use": http://prntscr.com/d1ghim 4) Change category to an invalid one (eg. Adult instead of Kid) 5) Error saying "Patron's age is incorrect for their category." should be displayed. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Lucio Moraes <lmoraes@catalyst.net.nz> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
I have found another bug which is critical in the same area (bug 17548), I have rebased this one on top of it.
Pushed to master for 16.11, thanks Radek!
(In reply to Kyle M Hall from comment #7) > Pushed to master for 16.11, thanks Radek! blocked by skipped patchset (17548), passing for 16.05