C4::Members::GetBorrowersWithEmail can be easily replaced with Koha::Patrons->search({ email => $email });
Created attachment 57207 [details] [review] Bug 17554: Koha::Patrons - Remove GetBorrowersWithEmail C4::Members::GetBorrowersWithEmail can be easily replaced with Koha::Patrons->search({ email => $email }); Test plan: Confirm that you are still able to use Persona for login http://translate.koha-community.org/manual/master/en/html-desktop/#mozillapersona For QA: Note that this is also use for the PKI authentication But as the code is the same I don't think it's needed to test both.
Created attachment 57208 [details] [review] Bug 17554: Koha::Patrons - Remove GetBorrowersWithEmail C4::Members::GetBorrowersWithEmail can be easily replaced with Koha::Patrons->search({ email => $email }); Test plan: Confirm that you are still able to use Persona for login http://translate.koha-community.org/manual/master/en/html-desktop/#mozillapersona For QA: Note that this is also use for the PKI authentication But as the code is the same I don't think it's needed to test both.
Created attachment 58184 [details] [review] Bug 17554: Koha::Patrons - Remove GetBorrowersWithEmail C4::Members::GetBorrowersWithEmail can be easily replaced with Koha::Patrons->search({ email => $email }); Test plan: Confirm that you are still able to use PKI authentication
Created attachment 58486 [details] [review] Bug 17554: Koha::Patrons - Remove GetBorrowersWithEmail C4::Members::GetBorrowersWithEmail can be easily replaced with Koha::Patrons->search({ email => $email }); Test plan: Confirm that you are still able to use PKI authentication
Alternative test plan: read the changes and confirm that they make sense.
Looks like a solid change to me, but I can't get it to apply :(
Created attachment 62956 [details] [review] Bug 17554: Koha::Patrons - Remove GetBorrowersWithEmail C4::Members::GetBorrowersWithEmail can be easily replaced with Koha::Patrons->search({ email => $email }); Test plan: Confirm that you are still able to use PKI authentication
Created attachment 64660 [details] [review] Bug 17554: Koha::Patrons - Remove GetBorrowersWithEmail C4::Members::GetBorrowersWithEmail can be easily replaced with Koha::Patrons->search({ email => $email }); Test plan: Confirm that you are still able to use PKI authentication Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 64661 [details] [review] Bug 17554: (followup) Shibboleth check should use ->find too There was a remaining use of C4::Members::GetBorrowersWithEmail in Auth.pm. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Simple patch, pretty trivial.
Pushed to master for 17.11, thanks to everybody involved!
Enhancement not pushed to 17.05.x