Certainly caused by bug 13321
Created attachment 57249 [details] [review] Bug 17562: Fix Acquisition.t I find these tests too much complicated and decided to remove them. They depends on the number of fields in the DB and any time we change this table we need to update the tests. As I don't understand the tests, I prefer to simply remove them, they don't seem very useful. Feel free to provide a counter patch if you think we should keep them. Test plan: prove t/db_dependent/Acquisition.t should return green
Created attachment 57251 [details] [review] [SIGNED-OFF] Bug 17562: Fix Acquisition.t I find these tests too much complicated and decided to remove them. They depends on the number of fields in the DB and any time we change this table we need to update the tests. As I don't understand the tests, I prefer to simply remove them, they don't seem very useful. Feel free to provide a counter patch if you think we should keep them. Test plan: prove t/db_dependent/Acquisition.t should return green Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 57396 [details] [review] Bug 17562: Fix Acquisition.t I find these tests too much complicated and decided to remove them. They depends on the number of fields in the DB and any time we change this table we need to update the tests. As I don't understand the tests, I prefer to simply remove them, they don't seem very useful. Feel free to provide a counter patch if you think we should keep them. Test plan: prove t/db_dependent/Acquisition.t should return green Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> This tests should be removed as this patch does.
Pushed to master for 16.11, thanks Jonathan!
(In reply to Kyle M Hall from comment #5) > Pushed to master for 16.11, thanks Jonathan! blocked by DB changes, passing for 16.05