Bug 17575 - Remove Circulation.t warnings
Summary: Remove Circulation.t warnings
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Test Suite (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Tomás Cohen Arazi (tcohen)
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on: 14598
Blocks:
  Show dependency tree / graph
 
Reported: 2016-11-07 18:59 UTC by Tomás Cohen Arazi (tcohen)
Modified: 2018-06-04 20:10 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Bug 17575: Remove itemtype-related warnings from Circulation.t (6.00 KB, patch)
2016-11-07 19:14 UTC, Tomás Cohen Arazi (tcohen) 		Details | Diff | Splinter Review
Bug 17575: (followup) Remove missing fine type warnings (1.53 KB, patch)
2016-11-07 19:14 UTC, Tomás Cohen Arazi (tcohen) 		Details | Diff | Splinter Review
[SIGNED-OFF] Bug 17575: Remove itemtype-related warnings from Circulation.t (6.06 KB, patch)
2016-11-07 21:36 UTC, Josef Moravec 		Details | Diff | Splinter Review
[SIGNED-OFF] Bug 17575: (followup) Remove missing fine type warnings (1.60 KB, patch)
2016-11-07 21:36 UTC, Josef Moravec 		Details | Diff | Splinter Review
Bug 17575: Remove itemtype-related warnings from Circulation.t (6.15 KB, patch)
2016-11-11 08:15 UTC, Marcel de Rooy 		Details | Diff | Splinter Review
Bug 17575: (followup) Remove missing fine type warnings (1.68 KB, patch)
2016-11-11 08:15 UTC, Marcel de Rooy 		Details | Diff | Splinter Review
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tomás Cohen Arazi (tcohen) 2016-11-07 18:59:50 UTC 
Bug 14598 made this tests raise lots of warnings because of incomplete data on sample items.
Comment 1 Tomás Cohen Arazi (tcohen) 2016-11-07 19:14:19 UTC 
Created attachment 57278 [details] [review]
Bug 17575: Remove itemtype-related warnings from Circulation.t

To test:
- Run:
  $ prove t/db_dependent/Circulation.t
=> FAIL: Lots of warnings
- Apply the patch
- Run:
  $ prove t/db_dependent/Circulation.t
=> SUCCESS: All green and no itemtype warnings
- Sign off :-D

Sponsored-by: ByWater Solutions
Comment 2 Tomás Cohen Arazi (tcohen) 2016-11-07 19:14:25 UTC 
Created attachment 57279 [details] [review]
Bug 17575: (followup) Remove missing fine type warnings

Sponsored-by: ByWater Solutions
Comment 3 Josef Moravec 2016-11-07 21:36:30 UTC 
Created attachment 57289 [details] [review]
[SIGNED-OFF] Bug 17575: Remove itemtype-related warnings from Circulation.t

To test:
- Run:
  $ prove t/db_dependent/Circulation.t
=> FAIL: Lots of warnings
- Apply the patch
- Run:
  $ prove t/db_dependent/Circulation.t
=> SUCCESS: All green and no itemtype warnings
- Sign off :-D

Sponsored-by: ByWater Solutions

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Comment 4 Josef Moravec 2016-11-07 21:36:36 UTC 
Created attachment 57290 [details] [review]
[SIGNED-OFF] Bug 17575: (followup) Remove missing fine type warnings

Sponsored-by: ByWater Solutions

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Comment 5 Marcel de Rooy 2016-11-11 08:15:11 UTC 
Created attachment 57446 [details] [review]
Bug 17575: Remove itemtype-related warnings from Circulation.t

To test:
- Run:
  $ prove t/db_dependent/Circulation.t
=> FAIL: Lots of warnings
- Apply the patch
- Run:
  $ prove t/db_dependent/Circulation.t
=> SUCCESS: All green and no itemtype warnings
- Sign off :-D

Sponsored-by: ByWater Solutions

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 6 Marcel de Rooy 2016-11-11 08:15:15 UTC 
Created attachment 57447 [details] [review]
Bug 17575: (followup) Remove missing fine type warnings

Sponsored-by: ByWater Solutions

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 7 Kyle M Hall (khall) 2016-11-12 02:36:08 UTC 
Pushed to master for 16.11, thanks Tomas!
Comment 8 Mason James 2016-12-14 10:48:49 UTC 
Pushed to 16.05.x, for 16.05.06 release