Created attachment 57309 [details] [review] Bug 17580: Add the Koha::Patron->get_overdues method This method will be used by several patches later. Test plan: prove t/db_dependent/Koha/Patrons.t should return green
Created attachment 57311 [details] [review] Bug 17580: Add the Koha::Patron->get_overdues method This method will be used by several patches later. Test plan: prove t/db_dependent/Koha/Patrons.t should return green
Created attachment 57314 [details] [review] Bug 17580: Add the Koha::Patron->get_overdues method This method will be used by several patches later. Test plan: prove t/db_dependent/Koha/Patrons.t should return green
Created attachment 57362 [details] [review] [SIGNED-OFF] Bug 17580: Add the Koha::Patron->get_overdues method This method will be used by several patches later. Test plan: prove t/db_dependent/Koha/Patrons.t should return green Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 57828 [details] [review] Bug 17580: Add the Koha::Patron->get_overdues method This method will be used by several patches later. Test plan: prove t/db_dependent/Koha/Patrons.t should return green Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Rebased removing the dependency on bug 16966
There's some dependency missing I guess.
(In reply to Tomás Cohen Arazi from comment #7) > There's some dependency missing I guess. Apply ok for me
t/db_dependent/Koha/Patrons.t .. 4/14 # No tests run! t/db_dependent/Koha/Patrons.t .. 13/14 # Failed test 'No tests run for subtest "get_overdues"' # at t/db_dependent/Koha/Patrons.t line 431. :1: parser error : Start tag expected, '<' not found EuExyYxkK ^ # Looks like your test exited with 255 just after 13. t/db_dependent/Koha/Patrons.t .. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 2/14 subtests Test Summary Report ------------------- t/db_dependent/Koha/Patrons.t (Wstat: 65280 Tests: 13 Failed: 1) Failed test: 13 Non-zero exit status: 255 Parse errors: Bad plan. You planned 14 tests but ran 13. Files=1, Tests=13, 4 wallclock secs ( 0.02 usr 0.01 sys + 3.09 cusr 0.12 csys = 3.24 CPU) Result: FAIL
Created attachment 57927 [details] [review] Bug 17580: Add the Koha::Patron->get_overdues method This method will be used by several patches later. Test plan: prove t/db_dependent/Koha/Patrons.t should return green Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Pushed to master for 17.05, thanks Jonathan!
This won't get backported to 16.11.x as it is an enhancement.
There is a follow-up for this on the master branch with a wrong bug number. It won't be needed in stable releases: Bug 17586 [QA Followup] - Correct the number of unit tests 46432511a600f0f22b35d004ee47eb573a33f94f