Created attachment 57333 [details] [review] Bug 17587: Remove itemtype-related IsItemIssued.t warnings This patch makes t/db_dependent/Circulation/IsItemIssued.t create good sample data for its tests. It does so by creating a random itemtype. To test: - Run $ prove t/db_dependent/Circulation/IsItemIssued.t => FAIL: lots of warnings about "item-level_itypes set but no itemtype set for item" - Apply the patch - Run: $ prove t/db_dependent/Circulation/IsItemIssued.t => SUCCESS: Tests are green, and no warnings. - Sign off :-D Sponsored-by: ByWater Solutions
Created attachment 57367 [details] [review] [SIGNED-OFF] Bug 17587: Remove itemtype-related IsItemIssued.t warnings This patch makes t/db_dependent/Circulation/IsItemIssued.t create good sample data for its tests. It does so by creating a random itemtype. To test: - Run $ prove t/db_dependent/Circulation/IsItemIssued.t => FAIL: lots of warnings about "item-level_itypes set but no itemtype set for item" - Apply the patch - Run: $ prove t/db_dependent/Circulation/IsItemIssued.t => SUCCESS: Tests are green, and no warnings. - Sign off :-D Sponsored-by: ByWater Solutions Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 57445 [details] [review] Bug 17587: Remove itemtype-related IsItemIssued.t warnings This patch makes t/db_dependent/Circulation/IsItemIssued.t create good sample data for its tests. It does so by creating a random itemtype. To test: - Run $ prove t/db_dependent/Circulation/IsItemIssued.t => FAIL: lots of warnings about "item-level_itypes set but no itemtype set for item" - Apply the patch - Run: $ prove t/db_dependent/Circulation/IsItemIssued.t => SUCCESS: Tests are green, and no warnings. - Sign off :-D Sponsored-by: ByWater Solutions Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Still one warning (out of scope): C4::Context->userenv not defined! at /usr/share/koha/masterclone/C4/Items.pm line 2267.
Pushed to master for 16.11, thanks Tomas!
Pushed to 16.05.x, for 16.05.06 release